Skip to content

fix!: rename the blockly icon CSS classes to use camelCase (#8329) - #8335

Merged
BeksOmega merged 1 commit into
RaspberryPiFoundation:rc/v12.0.0from
ga-fleury:feature/8329
Jul 12, 2024
Merged

fix!: rename the blockly icon CSS classes to use camelCase (#8329)#8335
BeksOmega merged 1 commit into
RaspberryPiFoundation:rc/v12.0.0from
ga-fleury:feature/8329

Conversation

@ga-fleury

Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Fixes Rename the blockly icon CSS classes to use camelCase #8329

Proposed Changes

Rename the following CSS classes and references to them:

.blockly-icon-comment -> blocklyCommentIcon
.blockly-icon-warning -> blocklyWarningIcon
.blockly-icon-mutator -> blocklyMutatorIcon

Reason for Changes

Test Coverage

Documentation

Additional Information

@ga-fleury
ga-fleury requested a review from a team as a code ownerJuly 12, 2024 13:15
@ga-fleury
ga-fleury requested a review from BeksOmegaJuly 12, 2024 13:15
@BeksOmegaBeksOmega changed the title Rename the blockly icon CSS classes to use camelCase (#8329)fix!: rename the blockly icon CSS classes to use camelCase (#8329)Jul 12, 2024
@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug labels Jul 12, 2024

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll get this merged once it passes CI

@BeksOmega
BeksOmega merged commit 9ba791c into RaspberryPiFoundation:rc/v12.0.0Jul 12, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking changeUsed to mark a PR or issue that changes our public APIs.PR: fixFixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ga-fleury@BeksOmega