Skip to content

refactor: Add addClass and removeClass methods to blockSvg - #8337

Merged
BeksOmega merged 3 commits into
RaspberryPiFoundation:rc/v12.0.0from
ishon19:refactor/8270-add-addclass-removeclass-to-blocksvg
Jul 15, 2024
Merged

refactor: Add addClass and removeClass methods to blockSvg#8337
BeksOmega merged 3 commits into
RaspberryPiFoundation:rc/v12.0.0from
ishon19:refactor/8270-add-addclass-removeclass-to-blocksvg

Conversation

@ishon19

@ishon19ishon19 commented Jul 12, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

The basics

The details

This PR add addClass and removeClass methods, which accept the class name as a parameter and can be used to perform the dom.addClass call rather than calling it directly.

Fixes#8270

@ishon19
ishon19 requested a review from a team as a code ownerJuly 12, 2024 14:45
@ishon19
ishon19 requested a review from cpcallenJuly 12, 2024 14:45
@github-actionsgithub-actionsBot added PR: refactor Refactors code and removed PR: refactor Refactors code labels Jul 12, 2024
@BeksOmega
BeksOmega requested review from BeksOmega and removed request for cpcallenJuly 12, 2024 15:58
@BeksOmegaBeksOmega assigned BeksOmega and unassigned cpcallenJul 12, 2024
BeksOmega
BeksOmega suggested changes Jul 12, 2024
View reviewed changes

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Just some docs nits. Once these are fixed I'll pull your changes down and give them a test.

Comment threadcore/block_svg.ts Outdated
Comment threadcore/block_svg.ts Outdated
Comment threadcore/block_svg.ts Outdated
@ishon19
ishon19 requested a review from BeksOmegaJuly 12, 2024 16:57
BeksOmega
BeksOmega approved these changes Jul 15, 2024
View reviewed changes

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Once CI passes I'll get this merged. Thanks for digging into this =)

@ishon19

ishon19 commented Jul 15, 2024

Copy link
Copy Markdown
ContributorAuthor

This LGTM! Once CI passes I'll get this merged. Thanks for digging into this =)

Thanks @BeksOmega!

@BeksOmega
BeksOmega merged commit 7c22c46 into RaspberryPiFoundation:rc/v12.0.0Jul 15, 2024
@BeksOmegaBeksOmega mentioned this pull request Jul 15, 2024
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@BeksOmegaBeksOmegaBeksOmega approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@BeksOmegaBeksOmega

Labels

PR: refactorRefactors code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ishon19@BeksOmega@cpcallen