Skip to content

fix!: Rename blocklyTreeRow and blocklyToolboxCategory CSS classes - #8357

Merged
BeksOmega merged 3 commits into
RaspberryPiFoundation:rc/v12.0.0from
Abhinav-Chdhary:rc/v12.0.0
Jul 16, 2024
Merged

fix!: Rename blocklyTreeRow and blocklyToolboxCategory CSS classes#8357
BeksOmega merged 3 commits into
RaspberryPiFoundation:rc/v12.0.0from
Abhinav-Chdhary:rc/v12.0.0

Conversation

@Abhinav-Chdhary

Copy link
Copy Markdown
Contributor

The basics

The details

  • This commit renames the blocklyTreeRow CSS class to blocklyToolboxCategory.
  • The commit was made against v12.0.0 branch
  • It is a breaking change

Fixes#8345

This commit renames the blocklyTreeRow CSS class to blocklyToolboxCategory
@Abhinav-Chdhary
Abhinav-Chdhary requested a review from a team as a code ownerJuly 14, 2024 02:25
@google-cla

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug labels Jul 14, 2024

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:

  • You can find tips about contributing to Blockly and how to validate your changes on our developer site.
  • All contributors must sign the Google Contributor License Agreement (CLA). If the google-cla bot leaves a comment on this PR, make sure you follow the instructions.
  • We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
  • If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
    Thank you for opening this PR! A member of the Blockly team will review it soon.

@Abhinav-ChdharyAbhinav-Chdhary changed the title fix!: #8345 rename css classfix!: #8345 rename a css classJul 14, 2024
@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed PR: fix Fixes a bug breaking change Used to mark a PR or issue that changes our public APIs. labels Jul 14, 2024
@BeksOmega
BeksOmega requested review from BeksOmega and removed request for gonfunkoJuly 15, 2024 17:25
@BeksOmegaBeksOmega assigned BeksOmega and unassigned gonfunkoJul 15, 2024

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this! Just a few fixes then should be gtg.

Comment threadcore/toolbox/category.ts

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes! But now it looks like some Mocha tests are failing. Could you look into what's going wrong? You can run them locally by doing npm run test:mocha:interactive.

@Abhinav-Chdhary

Copy link
Copy Markdown
ContributorAuthor

Thanks for the fixes! But now it looks like some Mocha tests are failing. Could you look into what's going wrong? You can run them locally by doing npm run test:mocha:interactive.

Yes definitely! Can you help me understand these errors?

image

I had also made the changes in test files, so that it simulates the click on blocklyToolboxCategory instead of blocklyTreeRow. That was the correct step right?
image

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see the issue, this is my bad. We've created a conflict between the CSS class of the container and the CSS class of the row. Could you name the original uses of blocklyToolboxCategory to blocklyToolboxCategoryContainer as well? I think that should fix the problem!

Rename original blocklyToolboxCategory to blocklyToolboxCategoryContainer
@Abhinav-Chdhary

Copy link
Copy Markdown
ContributorAuthor

Ah I see the issue, this is my bad. We've created a conflict between the CSS class of the container and the CSS class of the row. Could you name the original uses of blocklyToolboxCategory to blocklyToolboxCategoryContainer as well? I think that should fix the problem!

I have tried to do so. It passes all tests locally.

@BeksOmegaBeksOmega left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweetness! Thank you for the back and forth, this looks beautiful =)

@BeksOmegaBeksOmega changed the title fix!: #8345 rename a css classfix!: Rename blocklyTreeRow and blocklyToolboxCategory CSS classesJul 16, 2024
@github-actionsgithub-actionsBot added breaking change Used to mark a PR or issue that changes our public APIs. PR: fix Fixes a bug and removed PR: fix Fixes a bug breaking change Used to mark a PR or issue that changes our public APIs. labels Jul 16, 2024
@BeksOmega
BeksOmega merged commit ae2fea4 into RaspberryPiFoundation:rc/v12.0.0Jul 16, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking changeUsed to mark a PR or issue that changes our public APIs.PR: fixFixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Abhinav-Chdhary@BeksOmega@gonfunko