Uh oh!
There was an error while loading. Please reload this page.
chore(deps): Enable legacy-peer-deps, update @blockly/ plugins - #8366
Merged
cpcallen merged 3 commits intoJul 17, 2024
Conversation
Add legacy-peer-deps=true to .npmrc: - Doesn't install a second, probably out-of-date copy of Blockly in node_modules/blockly/. - Prevents version conflicts when trying to update @blockly/* dev dependencies, beause npm doesn't seem to be clever enough to resovle peer dependency version conflicts for the blockly package when updating plugins (which have blockly as a peer), even if all plugins are updated at the same time. - Brings the configuration of the blockly repo in line with blockly-samples, for whatever that is worth. (Might avoid problems during monorepo migration.)
Achieved by running: npm install --save-dev @blockly/theme-modern@latest @blockly/block-test@latest @blockly/dev-tools@latest
Our .eslintrc.js references th @typescript-eslint/parser plugin, but this plugin was not actually included in the devDependencies section in package.json.
rachel-fenichel
approved these changes
Jul 16, 2024
gonfunko pushed a commit
to gonfunko/blockly
that referenced
this pull request
Jul 18, 2024
…aspberryPiFoundation#8366) * chore(deps): Enable npm legacy-peer-deps option Add legacy-peer-deps=true to .npmrc: - Doesn't install a second, probably out-of-date copy of Blockly in node_modules/blockly/. - Prevents version conflicts when trying to update @blockly/* dev dependencies, beause npm doesn't seem to be clever enough to resovle peer dependency version conflicts for the blockly package when updating plugins (which have blockly as a peer), even if all plugins are updated at the same time. - Brings the configuration of the blockly repo in line with blockly-samples, for whatever that is worth. (Might avoid problems during monorepo migration.) * chore(deps): Update @blockly plugins following v11 release Achieved by running: npm install --save-dev @blockly/theme-modern@latest @blockly/block-test@latest @blockly/dev-tools@latest * chore(deps): Install missing @typescript-eslint/parser dev dependency Our .eslintrc.js references th @typescript-eslint/parser plugin, but this plugin was not actually included in the devDependencies section in package.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes CI failures in (and obsoletes) #8248.
Proposed Changes
legacy-peer-deps=truein.npmrc.@blockly/plugin dev deps to@latest.Reason for Changes
Enabling
legacy-peer-deps:node_modules/blockly/.@blockly/*dev dependencies, beacuse npm doesn't seem to be clever enough to resolve peer dependency version conflicts for theblocklypackage when updating plugins (which have blockly as a peer), even if all plugins are updated at the same time.Upgrading
@blockly/plugin dev dependencies:npm cifailures due to version conflicts for theblocklypeer dependency of those plugins.Test Coverage
Passes
npm test.