Uh oh!
There was an error while loading. Please reload this page.
refactor: make VariableMap implement IVariableMap. - #8395
Merged
gonfunko merged 5 commits intoJul 19, 2024
Conversation
gonfunkoforce-pushed
the
variable-map-implement
branch
from
July 18, 2024 19:18
40dfba0 to
76d05b7CompareBeksOmega
approved these changes
Jul 19, 2024
BeksOmega
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the late review!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
BeksOmega
approved these changes
Jul 19, 2024
BeksOmega
left a comment
Contributor
There was a problem hiding this comment.
Looks great =) Thanks for the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes#8074
Proposed Changes
This PR makes the existing VariableMap class implement the new IVariableMap interface. I also changed the backing store from a map of arrays to a map of maps, since this made implementing the new methods easier and allowed for efficiency improvements in some of the existing ones.