Skip to content

refactor!: Remove old cursor and tab support. - #8803

Merged
gonfunko merged 1 commit into
RaspberryPiFoundation:rc/v12.0.0from
gonfunko:accursed
Mar 28, 2025
Merged

refactor!: Remove old cursor and tab support.#8803
gonfunko merged 1 commit into
RaspberryPiFoundation:rc/v12.0.0from
gonfunko:accursed

Conversation

@gonfunko

Copy link
Copy Markdown
Contributor

The basics

The details

Resolves

Proposed Changes

This PR removes the BasicCursor and TabNavigateCursor classes. These provided limited support for keyboard navigation, and have been supplanted by the much-improved experience in https://github.com/google/blockly-keyboard-experimentation. The latter cursor was also used by input fields and blocks to provide support for tabbing between input fields on a block. This was limited to FieldInput subclasses, and has again been supplanted by the keyboard-experimentation plugin.

Breaking Changes

  • BasicCursor and TabNavigateCursor have been removed
  • Field.isTabNavigable() has been removed
  • BlockSvg.tab() has been removed

In all cases, use of the keyboard-experimentation plugin is the recommended migration path.

@gonfunko
gonfunko requested a review from a team as a code ownerMarch 12, 2025 21:29
@gonfunkogonfunko added breaking change Used to mark a PR or issue that changes our public APIs. PR: refactor Refactors code labels Mar 12, 2025
@gonfunkogonfunko reopened this Mar 18, 2025
@rachel-fenichelrachel-fenichel mentioned this pull request Mar 27, 2025
1 task
@rachel-fenichel

Copy link
Copy Markdown
Collaborator

I filed #8821 because we do want to keep some tab behaviour. You can merge this and then re-add tab through the main cursor, or you can do them as separate pieces of work--both work for me.

@gonfunko
gonfunko merged commit 7a07b4b into RaspberryPiFoundation:rc/v12.0.0Mar 28, 2025
@gonfunko
gonfunko deleted the accursed branch March 28, 2025 20:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking changeUsed to mark a PR or issue that changes our public APIs.PR: refactorRefactors code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gonfunko@rachel-fenichel