fix: fieldDropdown.getText works in node by maribethb · Pull Request #9048 · RaspberryPiFoundation/blockly

maribethb · 2025-05-14T17:51:57Z

The basics

I validated my changes

The details

Resolves

Fixes#9035

Proposed Changes

Checks that HTMLElement is defined before trying to use it

Reason for Changes

Dropdown fields should work in node

Test Coverage

Added a node test to make sure this change fixes the CI problems we saw in samples

Documentation

I logged a warning for the case that would hit if:

Someone uses a FieldDropdown with HTMLElement options
They use node, haven't supplied an implementation of HTMLElement, and call getText.

Honestly the chances anyone does this and doesn't run into a number of other issues is relatively small, but hopefully the warning message helps them out if so.

If someone is using node with just regular text options, they don't need to supply an implementation of HTMLElement and won't see the warning, so this doesn't affect the usual case (and before v12, the only case, as it wasn't possible to use element options).

Additional Information

google-cla · 2025-05-14T17:52:14Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

maribethb · 2025-05-14T18:51:39Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

BenHenning

Thanks @maribethb! Approving to unblock, but had some thoughts (most of which likely don't need to happen now for v12).

BenHenning · 2025-05-14T18:50:19Z


 assert.deepEqual(jsonAfter, json);
 });
+ test('Dropdown getText works with no HTMLElement defined', function () {


Just to check: this test fails without the fix in place, right?

BenHenning · 2025-05-14T18:53:52Z

+ "you're using HTMLElement dropdown options in node, ensure you're " +
+ 'using jsdom-global or similar.',
+ );
+ return null;


Is it worth verifying the console warning & null case in tests?

No, because in order to get here you'd have to pass something that is an HTMElement type but then don't have HTMLElement defined. It would be really annoying to set up in tests and is a scenario that is unlikely to happen at all. But I had to return null to satisfy the ts compiler and the warning helps figure out why that is, in the off chance it ever somehow does happen.

maribethb · 2025-05-14T17:51:57Z

The basics

I validated my changes

The details

Resolves

Fixes#9035

Proposed Changes

Checks that HTMLElement is defined before trying to use it

Reason for Changes

Dropdown fields should work in node

Test Coverage

Added a node test to make sure this change fixes the CI problems we saw in samples

Documentation

I logged a warning for the case that would hit if:

Someone uses a FieldDropdown with HTMLElement options
They use node, haven't supplied an implementation of HTMLElement, and call getText.

Honestly the chances anyone does this and doesn't run into a number of other issues is relatively small, but hopefully the warning message helps them out if so.

If someone is using node with just regular text options, they don't need to supply an implementation of HTMLElement and won't see the warning, so this doesn't affect the usual case (and before v12, the only case, as it wasn't possible to use element options).

Additional Information

google-cla · 2025-05-14T17:52:14Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

maribethb · 2025-05-14T18:51:39Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

BenHenning

Thanks @maribethb! Approving to unblock, but had some thoughts (most of which likely don't need to happen now for v12).

BenHenning · 2025-05-14T18:50:19Z


 assert.deepEqual(jsonAfter, json);
 });
+ test('Dropdown getText works with no HTMLElement defined', function () {


Just to check: this test fails without the fix in place, right?

BenHenning · 2025-05-14T18:53:52Z

+ "you're using HTMLElement dropdown options in node, ensure you're " +
+ 'using jsdom-global or similar.',
+ );
+ return null;


Is it worth verifying the console warning & null case in tests?

No, because in order to get here you'd have to pass something that is an HTMElement type but then don't have HTMLElement defined. It would be really annoying to set up in tests and is a scenario that is unlikely to happen at all. But I had to return null to satisfy the ts compiler and the warning helps figure out why that is, in the off chance it ever somehow does happen.

maribethb · 2025-05-14T17:51:57Z

The basics

I validated my changes

The details

Resolves

Fixes#9035

Proposed Changes

Checks that HTMLElement is defined before trying to use it

Reason for Changes

Dropdown fields should work in node

Test Coverage

Added a node test to make sure this change fixes the CI problems we saw in samples

Documentation

I logged a warning for the case that would hit if:

Someone uses a FieldDropdown with HTMLElement options
They use node, haven't supplied an implementation of HTMLElement, and call getText.

Honestly the chances anyone does this and doesn't run into a number of other issues is relatively small, but hopefully the warning message helps them out if so.

If someone is using node with just regular text options, they don't need to supply an implementation of HTMLElement and won't see the warning, so this doesn't affect the usual case (and before v12, the only case, as it wasn't possible to use element options).

Additional Information

google-cla · 2025-05-14T17:52:14Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

maribethb · 2025-05-14T18:51:39Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

BenHenning

Thanks @maribethb! Approving to unblock, but had some thoughts (most of which likely don't need to happen now for v12).

BenHenning · 2025-05-14T18:50:19Z


 assert.deepEqual(jsonAfter, json);
 });
+ test('Dropdown getText works with no HTMLElement defined', function () {


Just to check: this test fails without the fix in place, right?

BenHenning · 2025-05-14T18:53:52Z

+ "you're using HTMLElement dropdown options in node, ensure you're " +
+ 'using jsdom-global or similar.',
+ );
+ return null;


Is it worth verifying the console warning & null case in tests?

No, because in order to get here you'd have to pass something that is an HTMElement type but then don't have HTMLElement defined. It would be really annoying to set up in tests and is a scenario that is unlikely to happen at all. But I had to return null to satisfy the ts compiler and the warning helps figure out why that is, in the off chance it ever somehow does happen.

maribethb · 2025-05-14T17:51:57Z

The basics

I validated my changes

The details

Resolves

Fixes#9035

Proposed Changes

Checks that HTMLElement is defined before trying to use it

Reason for Changes

Dropdown fields should work in node

Test Coverage

Added a node test to make sure this change fixes the CI problems we saw in samples

Documentation

I logged a warning for the case that would hit if:

Someone uses a FieldDropdown with HTMLElement options
They use node, haven't supplied an implementation of HTMLElement, and call getText.

Honestly the chances anyone does this and doesn't run into a number of other issues is relatively small, but hopefully the warning message helps them out if so.

If someone is using node with just regular text options, they don't need to supply an implementation of HTMLElement and won't see the warning, so this doesn't affect the usual case (and before v12, the only case, as it wasn't possible to use element options).

Additional Information

google-cla · 2025-05-14T17:52:14Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

maribethb · 2025-05-14T18:51:39Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

BenHenning

Thanks @maribethb! Approving to unblock, but had some thoughts (most of which likely don't need to happen now for v12).

BenHenning · 2025-05-14T18:50:19Z


 assert.deepEqual(jsonAfter, json);
 });
+ test('Dropdown getText works with no HTMLElement defined', function () {


Just to check: this test fails without the fix in place, right?

BenHenning · 2025-05-14T18:53:52Z

+ "you're using HTMLElement dropdown options in node, ensure you're " +
+ 'using jsdom-global or similar.',
+ );
+ return null;


Is it worth verifying the console warning & null case in tests?

No, because in order to get here you'd have to pass something that is an HTMElement type but then don't have HTMLElement defined. It would be really annoying to set up in tests and is a scenario that is unlikely to happen at all. But I had to return null to satisfy the ts compiler and the warning helps figure out why that is, in the off chance it ever somehow does happen.

maribethb · 2025-05-14T17:51:57Z

The basics

I validated my changes

The details

Resolves

Fixes#9035

Proposed Changes

Checks that HTMLElement is defined before trying to use it

Reason for Changes

Dropdown fields should work in node

Test Coverage

Added a node test to make sure this change fixes the CI problems we saw in samples

Documentation

I logged a warning for the case that would hit if:

Someone uses a FieldDropdown with HTMLElement options
They use node, haven't supplied an implementation of HTMLElement, and call getText.

Honestly the chances anyone does this and doesn't run into a number of other issues is relatively small, but hopefully the warning message helps them out if so.

If someone is using node with just regular text options, they don't need to supply an implementation of HTMLElement and won't see the warning, so this doesn't affect the usual case (and before v12, the only case, as it wasn't possible to use element options).

Additional Information

google-cla · 2025-05-14T17:52:14Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

maribethb · 2025-05-14T18:51:39Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

BenHenning

Thanks @maribethb! Approving to unblock, but had some thoughts (most of which likely don't need to happen now for v12).

BenHenning · 2025-05-14T18:50:19Z


 assert.deepEqual(jsonAfter, json);
 });
+ test('Dropdown getText works with no HTMLElement defined', function () {


Just to check: this test fails without the fix in place, right?

BenHenning · 2025-05-14T18:53:52Z

+ "you're using HTMLElement dropdown options in node, ensure you're " +
+ 'using jsdom-global or similar.',
+ );
+ return null;


Is it worth verifying the console warning & null case in tests?

No, because in order to get here you'd have to pass something that is an HTMElement type but then don't have HTMLElement defined. It would be really annoying to set up in tests and is a scenario that is unlikely to happen at all. But I had to return null to satisfy the ts compiler and the warning helps figure out why that is, in the off chance it ever somehow does happen.

maribethb · 2025-05-14T17:51:57Z

The basics

I validated my changes

The details

Resolves

Fixes#9035

Proposed Changes

Checks that HTMLElement is defined before trying to use it

Reason for Changes

Dropdown fields should work in node

Test Coverage

Added a node test to make sure this change fixes the CI problems we saw in samples

Documentation

I logged a warning for the case that would hit if:

Someone uses a FieldDropdown with HTMLElement options
They use node, haven't supplied an implementation of HTMLElement, and call getText.

Honestly the chances anyone does this and doesn't run into a number of other issues is relatively small, but hopefully the warning message helps them out if so.

If someone is using node with just regular text options, they don't need to supply an implementation of HTMLElement and won't see the warning, so this doesn't affect the usual case (and before v12, the only case, as it wasn't possible to use element options).

Additional Information

google-cla · 2025-05-14T17:52:14Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

maribethb · 2025-05-14T18:51:39Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

BenHenning

Thanks @maribethb! Approving to unblock, but had some thoughts (most of which likely don't need to happen now for v12).

BenHenning · 2025-05-14T18:50:19Z


 assert.deepEqual(jsonAfter, json);
 });
+ test('Dropdown getText works with no HTMLElement defined', function () {


Just to check: this test fails without the fix in place, right?

BenHenning · 2025-05-14T18:53:52Z

+ "you're using HTMLElement dropdown options in node, ensure you're " +
+ 'using jsdom-global or similar.',
+ );
+ return null;


Is it worth verifying the console warning & null case in tests?

No, because in order to get here you'd have to pass something that is an HTMElement type but then don't have HTMLElement defined. It would be really annoying to set up in tests and is a scenario that is unlikely to happen at all. But I had to return null to satisfy the ts compiler and the warning helps figure out why that is, in the off chance it ever somehow does happen.

maribethb · 2025-05-14T17:51:57Z

The basics

I validated my changes

The details

Resolves

Fixes#9035

Proposed Changes

Checks that HTMLElement is defined before trying to use it

Reason for Changes

Dropdown fields should work in node

Test Coverage

Added a node test to make sure this change fixes the CI problems we saw in samples

Documentation

I logged a warning for the case that would hit if:

Someone uses a FieldDropdown with HTMLElement options
They use node, haven't supplied an implementation of HTMLElement, and call getText.

Honestly the chances anyone does this and doesn't run into a number of other issues is relatively small, but hopefully the warning message helps them out if so.

If someone is using node with just regular text options, they don't need to supply an implementation of HTMLElement and won't see the warning, so this doesn't affect the usual case (and before v12, the only case, as it wasn't possible to use element options).

Additional Information

google-cla · 2025-05-14T17:52:14Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

maribethb · 2025-05-14T18:51:39Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

BenHenning

Thanks @maribethb! Approving to unblock, but had some thoughts (most of which likely don't need to happen now for v12).

BenHenning · 2025-05-14T18:50:19Z


 assert.deepEqual(jsonAfter, json);
 });
+ test('Dropdown getText works with no HTMLElement defined', function () {


Just to check: this test fails without the fix in place, right?

BenHenning · 2025-05-14T18:53:52Z

+ "you're using HTMLElement dropdown options in node, ensure you're " +
+ 'using jsdom-global or similar.',
+ );
+ return null;


Is it worth verifying the console warning & null case in tests?

No, because in order to get here you'd have to pass something that is an HTMElement type but then don't have HTMLElement defined. It would be really annoying to set up in tests and is a scenario that is unlikely to happen at all. But I had to return null to satisfy the ts compiler and the warning helps figure out why that is, in the off chance it ever somehow does happen.

maribethb · 2025-05-14T17:51:57Z

The basics

I validated my changes

The details

Resolves

Fixes#9035

Proposed Changes

Checks that HTMLElement is defined before trying to use it

Reason for Changes

Dropdown fields should work in node

Test Coverage

Added a node test to make sure this change fixes the CI problems we saw in samples

Documentation

I logged a warning for the case that would hit if:

Someone uses a FieldDropdown with HTMLElement options
They use node, haven't supplied an implementation of HTMLElement, and call getText.

Honestly the chances anyone does this and doesn't run into a number of other issues is relatively small, but hopefully the warning message helps them out if so.

If someone is using node with just regular text options, they don't need to supply an implementation of HTMLElement and won't see the warning, so this doesn't affect the usual case (and before v12, the only case, as it wasn't possible to use element options).

Additional Information

google-cla · 2025-05-14T17:52:14Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

maribethb · 2025-05-14T18:51:39Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.

BenHenning

Thanks @maribethb! Approving to unblock, but had some thoughts (most of which likely don't need to happen now for v12).

BenHenning · 2025-05-14T18:50:19Z


 assert.deepEqual(jsonAfter, json);
 });
+ test('Dropdown getText works with no HTMLElement defined', function () {


Just to check: this test fails without the fix in place, right?

BenHenning · 2025-05-14T18:53:52Z

+ "you're using HTMLElement dropdown options in node, ensure you're " +
+ 'using jsdom-global or similar.',
+ );
+ return null;


Is it worth verifying the console warning & null case in tests?

No, because in order to get here you'd have to pass something that is an HTMElement type but then don't have HTMLElement defined. It would be really annoying to set up in tests and is a scenario that is unlikely to happen at all. But I had to return null to satisfy the ts compiler and the warning helps figure out why that is, in the off chance it ever somehow does happen.

fix: dropdown getText works in node
ff45e68

maribethb requested a review from a team as a code owner May 14, 2025 17:51

maribethb requested a review from cpcallen May 14, 2025 17:51

github-actionsBot assigned cpcallen May 14, 2025

maribethb changed the base branch from develop to rc/v12.0.0May 14, 2025 17:52

maribethb changed the title ~~Htmlelement~~fix: fieldDropdown.getText works in nodeMay 14, 2025

maribethb added the PR: fix Fixes a bug label May 14, 2025

github-actionsBot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 14, 2025

BenHenning approved these changes May 14, 2025
View reviewed changes

chore: comment
a051dd1

maribethb merged commit 523dca9 into RaspberryPiFoundation:rc/v12.0.0May 14, 2025

gonfunko mentioned this pull request May 14, 2025
fix: Fix bug when referencing HTMLElement in non-browser environments. #9050
Merged
1 task

maribethb deleted the htmlelement branch July 7, 2026 20:13

fix: dropdown getText works in node
ff45e68

maribethb requested a review from a team as a code owner May 14, 2025 17:51

maribethb requested a review from cpcallen May 14, 2025 17:51

github-actionsBot assigned cpcallen May 14, 2025

maribethb changed the base branch from develop to rc/v12.0.0May 14, 2025 17:52

maribethb changed the title ~~Htmlelement~~fix: fieldDropdown.getText works in nodeMay 14, 2025

maribethb added the PR: fix Fixes a bug label May 14, 2025

github-actionsBot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 14, 2025

BenHenning approved these changes May 14, 2025
View reviewed changes

chore: comment
a051dd1

maribethb merged commit 523dca9 into RaspberryPiFoundation:rc/v12.0.0May 14, 2025

gonfunko mentioned this pull request May 14, 2025
fix: Fix bug when referencing HTMLElement in non-browser environments. #9050
Merged
1 task

maribethb deleted the htmlelement branch July 7, 2026 20:13

fix: dropdown getText works in node
ff45e68

maribethb requested a review from a team as a code owner May 14, 2025 17:51

maribethb requested a review from cpcallen May 14, 2025 17:51

github-actionsBot assigned cpcallen May 14, 2025

maribethb changed the base branch from develop to rc/v12.0.0May 14, 2025 17:52

maribethb changed the title ~~Htmlelement~~fix: fieldDropdown.getText works in nodeMay 14, 2025

maribethb added the PR: fix Fixes a bug label May 14, 2025

github-actionsBot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 14, 2025

BenHenning approved these changes May 14, 2025
View reviewed changes

chore: comment
a051dd1

maribethb merged commit 523dca9 into RaspberryPiFoundation:rc/v12.0.0May 14, 2025

gonfunko mentioned this pull request May 14, 2025
fix: Fix bug when referencing HTMLElement in non-browser environments. #9050
Merged
1 task

maribethb deleted the htmlelement branch July 7, 2026 20:13

fix: dropdown getText works in node
ff45e68

maribethb requested a review from a team as a code owner May 14, 2025 17:51

maribethb requested a review from cpcallen May 14, 2025 17:51

github-actionsBot assigned cpcallen May 14, 2025

maribethb changed the base branch from develop to rc/v12.0.0May 14, 2025 17:52

maribethb changed the title ~~Htmlelement~~fix: fieldDropdown.getText works in nodeMay 14, 2025

maribethb added the PR: fix Fixes a bug label May 14, 2025

github-actionsBot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 14, 2025

BenHenning approved these changes May 14, 2025
View reviewed changes

chore: comment
a051dd1

maribethb merged commit 523dca9 into RaspberryPiFoundation:rc/v12.0.0May 14, 2025

gonfunko mentioned this pull request May 14, 2025
fix: Fix bug when referencing HTMLElement in non-browser environments. #9050
Merged
1 task

maribethb deleted the htmlelement branch July 7, 2026 20:13

fix: dropdown getText works in node
ff45e68

maribethb requested a review from a team as a code owner May 14, 2025 17:51

maribethb requested a review from cpcallen May 14, 2025 17:51

github-actionsBot assigned cpcallen May 14, 2025

maribethb changed the base branch from develop to rc/v12.0.0May 14, 2025 17:52

maribethb changed the title ~~Htmlelement~~fix: fieldDropdown.getText works in nodeMay 14, 2025

maribethb added the PR: fix Fixes a bug label May 14, 2025

github-actionsBot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 14, 2025

BenHenning approved these changes May 14, 2025
View reviewed changes

chore: comment
a051dd1

maribethb merged commit 523dca9 into RaspberryPiFoundation:rc/v12.0.0May 14, 2025

gonfunko mentioned this pull request May 14, 2025
fix: Fix bug when referencing HTMLElement in non-browser environments. #9050
Merged
1 task

maribethb deleted the htmlelement branch July 7, 2026 20:13

fix: dropdown getText works in node
ff45e68

maribethb requested a review from a team as a code owner May 14, 2025 17:51

maribethb requested a review from cpcallen May 14, 2025 17:51

github-actionsBot assigned cpcallen May 14, 2025

maribethb changed the base branch from develop to rc/v12.0.0May 14, 2025 17:52

maribethb changed the title ~~Htmlelement~~fix: fieldDropdown.getText works in nodeMay 14, 2025

maribethb added the PR: fix Fixes a bug label May 14, 2025

github-actionsBot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 14, 2025

BenHenning approved these changes May 14, 2025
View reviewed changes

chore: comment
a051dd1

maribethb merged commit 523dca9 into RaspberryPiFoundation:rc/v12.0.0May 14, 2025

gonfunko mentioned this pull request May 14, 2025
fix: Fix bug when referencing HTMLElement in non-browser environments. #9050
Merged
1 task

maribethb deleted the htmlelement branch July 7, 2026 20:13

fix: dropdown getText works in node
ff45e68

maribethb requested a review from a team as a code owner May 14, 2025 17:51

maribethb requested a review from cpcallen May 14, 2025 17:51

github-actionsBot assigned cpcallen May 14, 2025

maribethb changed the base branch from develop to rc/v12.0.0May 14, 2025 17:52

maribethb changed the title ~~Htmlelement~~fix: fieldDropdown.getText works in nodeMay 14, 2025

maribethb added the PR: fix Fixes a bug label May 14, 2025

github-actionsBot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 14, 2025

BenHenning approved these changes May 14, 2025
View reviewed changes

chore: comment
a051dd1

maribethb merged commit 523dca9 into RaspberryPiFoundation:rc/v12.0.0May 14, 2025

gonfunko mentioned this pull request May 14, 2025
fix: Fix bug when referencing HTMLElement in non-browser environments. #9050
Merged
1 task

maribethb deleted the htmlelement branch July 7, 2026 20:13

fix: dropdown getText works in node
ff45e68

maribethb requested a review from a team as a code owner May 14, 2025 17:51

maribethb requested a review from cpcallen May 14, 2025 17:51

github-actionsBot assigned cpcallen May 14, 2025

maribethb changed the base branch from develop to rc/v12.0.0May 14, 2025 17:52

maribethb changed the title ~~Htmlelement~~fix: fieldDropdown.getText works in nodeMay 14, 2025

maribethb added the PR: fix Fixes a bug label May 14, 2025

github-actionsBot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 14, 2025

BenHenning approved these changes May 14, 2025
View reviewed changes

chore: comment
a051dd1

maribethb merged commit 523dca9 into RaspberryPiFoundation:rc/v12.0.0May 14, 2025

gonfunko mentioned this pull request May 14, 2025
fix: Fix bug when referencing HTMLElement in non-browser environments. #9050
Merged
1 task

maribethb deleted the htmlelement branch July 7, 2026 20:13

Uh oh!

Conversation

maribethb commented May 14, 2025

The basics

The details

Resolves

Proposed Changes

Reason for Changes

Test Coverage

Documentation

Additional Information

Uh oh!

google-claBot commented May 14, 2025

Uh oh!

maribethb commented May 14, 2025

Uh oh!

BenHenning left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

maribethb commented May 14, 2025

The basics

The details

Resolves

Proposed Changes

Reason for Changes

Test Coverage

Documentation

Additional Information

Uh oh!

google-claBot commented May 14, 2025

Uh oh!

maribethb commented May 14, 2025

Uh oh!

BenHenning left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

maribethb commented May 14, 2025

The basics

The details

Resolves

Proposed Changes

Reason for Changes