Uh oh!
There was an error while loading. Please reload this page.
fix: Improve workspace comment keyboard navigation behavior. - #9211
Conversation
maribethb
left a comment
There was a problem hiding this comment.
lgtm when tests pass. though i don't think the current approach to scrolling into view is very nice, that is a long term problem to fix.
do you think we need an interface for "Scroll-into-view-able"?
or should these components do this automatically in their "onNodeFocus" methods? is there a time when a node is focused that we wouldn't want to scroll them into view?
these are just rhetorical questions for now. i'll file an issue for them.
gonfunko
commented
Jul 7, 2025
Thanks! I don't think the test failures are actually related to this PR - they pass locally, and nothing in this would make Blockly.getMainWorkspace() not be a function. |
maribethb
commented
Jul 7, 2025
fair, i didn't investigate what the failures actually were |
The basics
The details
This PR addresses two points of feedback raised in RaspberryPiFoundation/blockly-keyboard-experimentation#625: