1.x: Run tests on Android! by artem-zinnatullin · Pull Request #3519 · ReactiveX/RxJava

artem-zinnatullin · 2015-11-13T04:40:01Z

Closes#3503.

In short:

Created rxjava gradle module and moved src to rxjava/src.
Created android-tests module and configured it to run tests from rxjava/src/test on Android.
Tuned build scripts so we can run builds on Android/JDK concurrently.
Changed MemoryMXBean to Runtime in ExecutorSchedulerTest because MemoryMXBean is not presented on Android.

TODO:

Fix all failing tests Android (usually timeout problems since Android emulator is 🐌): 1.x: Test adjustments to reduce problems when tests run on Android #3504, cc @akarnokd.
Decide which Android APIs we want to run tests on, I suggest at least one API with Dalvik VM (with Java 6 and Java 7) and one with ART, for example 18, 19 and 22.

@JakeWharton PTAL

JakeWharton · 2015-11-13T04:47:30Z

Not needed. .travis.yml takes care of this.

It's for developers, I guess @akarnokd used it without noticing :)
On Fri, Nov 13, 2015, 07:47 Jake Wharton notifications@github.com wrote:
In android-tests/build.gradle
#3519 (comment):
@@ -0,0 +1,61 @@
+buildscript {
repositories {
jcenter()
}
dependencies {
// Android Gradle plugin
classpath 'com.android.tools.build:gradle:1.3.1'
// Resolves android-sdk dependencies
classpath 'com.jakewharton.sdkmanager:gradle-plugin:0.12.0'
Not needed. .travis.yml takes care of this.
—
Reply to this email directly or view it on GitHub
https://github.com/ReactiveX/RxJava/pull/3519/files#r44749555.
@artem_zin

I'm amazed it even still works.
On Thu, Nov 12, 2015 at 11:51 PM Artem Zinnatullin notifications@github.com
wrote:
In android-tests/build.gradle
#3519 (comment):
@@ -0,0 +1,61 @@
+buildscript {
repositories {
jcenter()
}
dependencies {
// Android Gradle plugin
classpath 'com.android.tools.build:gradle:1.3.1'
// Resolves android-sdk dependencies
classpath 'com.jakewharton.sdkmanager:gradle-plugin:0.12.0'
It's for developers, I guess @akarnokd https://github.com/akarnokd used
it without noticing :)
On Fri, Nov 13, 2015, 07:47 Jake Wharton notifications@github.com
wrote: In android-tests/build.gradle <#3519 (comment)
https://github.com/ReactiveX/RxJava/pull/3519#discussion_r44749555>: >
@@ -0,0 +1,61 @@ > +buildscript { > + repositories { > + jcenter() > + } >
dependencies { > + // Android Gradle plugin > + classpath
'com.android.tools.build:gradle:1.3.1' > + > + // Resolves android-sdk
dependencies > + classpath
'com.jakewharton.sdkmanager:gradle-plugin:0.12.0' Not needed. .travis.yml
takes care of this. — Reply to this email directly or view it on GitHub <
https://github.com/ReactiveX/RxJava/pull/3519/files#r44749555>.
-- @artem_zin
—
Reply to this email directly or view it on GitHub
https://github.com/ReactiveX/RxJava/pull/3519/files#r44749702.

Well, would be nice to see new releases! Sometimes it can not handle
support libraries updates. But anyway, great tool.
On Fri, Nov 13, 2015, 07:52 Jake Wharton notifications@github.com wrote:
In android-tests/build.gradle
#3519 (comment):
@@ -0,0 +1,61 @@
+buildscript {
repositories {
jcenter()
}
dependencies {
// Android Gradle plugin
classpath 'com.android.tools.build:gradle:1.3.1'
// Resolves android-sdk dependencies
classpath 'com.jakewharton.sdkmanager:gradle-plugin:0.12.0'
I'm amazed it even still works.
… <#msg-f:1517698800156585010_>
On Thu, Nov 12, 2015 at 11:51 PM Artem Zinnatullin <
notifications@github.com> wrote: In android-tests/build.gradle <#3519
(comment)
https://github.com/ReactiveX/RxJava/pull/3519#discussion_r44749702>: >
@@ -0,0 +1,61 @@ > +buildscript { > + repositories { > + jcenter() > + } >
dependencies { > + // Android Gradle plugin > + classpath
'com.android.tools.build:gradle:1.3.1' > + > + // Resolves android-sdk
dependencies > + classpath
'com.jakewharton.sdkmanager:gradle-plugin:0.12.0' It's for developers, I
guess @akarnokd https://github.com/akarnokd https://github.com/akarnokd
used it without noticing :) On Fri, Nov 13, 2015, 07:47 Jake Wharton <
notifications@github.com> wrote: In android-tests/build.gradle <1.x: Run tests on Android! #3519
1.x: Run tests on Android! #3519 (comment) <1.x: Run tests on Android! #3519 (comment)
https://github.com/ReactiveX/RxJava/pull/3519#discussion_r44749555>>: >
@@ -0,0 +1,61 @@ > +buildscript { > + repositories { > + jcenter() > + } >
dependencies { > + // Android Gradle plugin > + classpath
'com.android.tools.build:gradle:1.3.1' > + > + // Resolves android-sdk
dependencies > + classpath
'com.jakewharton.sdkmanager:gradle-plugin:0.12.0' Not needed. .travis.yml
takes care of this. — Reply to this email directly or view it on GitHub <
https://github.com/ReactiveX/RxJava/pull/3519/files#r44749555>. --
@artem_zin — Reply to this email directly or view it on GitHub <
https://github.com/ReactiveX/RxJava/pull/3519/files#r44749702>.
—
Reply to this email directly or view it on GitHub
https://github.com/ReactiveX/RxJava/pull/3519/files#r44749727.
@artem_zin

akarnokd · 2015-11-13T08:31:32Z

Can we do this without moving any files?

artem-zinnatullin · 2015-11-13T12:10:46Z

Can we do this without moving any files?

Not sure, unfortunately. src is default source root it will probably be bound to the root Gradle project and I'm not sure that I'll be able to detach it from root project.

Though I'll try it today, if somebody already done this — please comment.

artem-zinnatullin · 2015-11-15T02:02:33Z

@akarnokd done!

akarnokd · 2015-11-17T08:42:24Z

This fails for some reason. Maybe the underlying thread dies off?
Could you change the code above to use a ThreadFactory with newSingleThreadExecutor and set the uncaught exception handler within the factory?

akarnokd · 2015-11-22T09:32:11Z

Generally, I'm not against testing on Android but I'm afraid it will hinder progress on RxJava due to platform nuances. I remember when RxJava had every other Rx language and tool under the same main project and a change for Java caused build failures because something didn't compile in RxScala or some test failed in RxClojure. Would it be possible to have this as a separate project where Gradle/travis checks out the RxJava code from github and runs the tests on the emulator?

artem-zinnatullin · 2015-11-22T16:13:02Z

Android is just another Runtime, see it as different JVM (though it's not J-VM, but it does not matter in this case). Scala, Clojure, etc run on the JVM too, so your example is not directly applicable to the intention of running tests on Android. Your example is more about RxAndroid and I agree that it should be separate project and it is in .

Thousands of Android apps use RxJava, millions of Android devices run RxJava code every minute. And RxJava has some Platform-dependent code. Would be great to check that it works as expected 😄

Would it be possible to have this as a separate project where Gradle/travis checks out the RxJava code from github and runs the tests on the emulator?

It's possible, but it will be very hard since it requires changes of the tests (timeouts, etc). Also, it won't give immediate feedback to PRs in the RxJava.

I'm sorry for the delay with this PR, I'm very busy this week, will try to finish it soon.

avram · 2016-02-03T17:15:43Z

It's possible, but it will be very hard since it requires changes of the tests (timeouts, etc). Also, it won't give immediate feedback to PRs in the RxJava.

With appropriate privileging, a secondary RxJava test runner outside of this repo could still post status checks to PRs -- it probably couldn't easily use Travis, but a custom runner on Jenkins would have enough flexibility to do that. Concerns about changes to tests would still remain.

artem-zinnatullin · 2016-02-03T17:31:54Z

I'd still prefer to run tests on Android as part of current RxJava CI, actually there're just few tests fail with timeouts because Android emulator is slow as hell, we can write custom test runner or JUnit rule and add AndroidTimeout annotation to fix that and not touch regular tests runs.

Please feel free (anyone) to work on this, hopefully I'll do it at some point, but I don't have much time right now.

akarnokd · 2016-06-17T07:25:44Z

I'm still not in favor of running the tests for Android in the same CI process.

The alternative I see is to somehow package up the unit tests as well and have a separate project run it it, or if a gradle script could be written to checkout the RxJava sources and run the tests in that way.

artem-zinnatullin · 2016-06-17T09:18:28Z

Let's close it for now, I have a task to run RxJava tests on Android as part of CI of RxJavaProGuardRules project.

Hope I'll find some time to work on it in the summer.

JakeWharton reviewed Nov 13, 2015
View reviewed changes

artem-zinnatullin force-pushed the run-tests-on-android branch 2 times, most recently from 93e9322 to f7a1c58Compare November 15, 2015 01:54

artem-zinnatullin force-pushed the run-tests-on-android branch from f7a1c58 to 2cb70dcCompare November 15, 2015 16:56

Run tests on Android!
8fdaf38

artem-zinnatullin force-pushed the run-tests-on-android branch from 2cb70dc to 8fdaf38Compare November 15, 2015 17:15

akarnokd added the Test label Nov 16, 2015

akarnokd reviewed Nov 17, 2015
View reviewed changes

akarnokd changed the title ~~Run tests on Android!~~1.x: Run tests on Android!Feb 9, 2016

artem-zinnatullin closed this Jun 17, 2016

akarnokd mentioned this pull request Jun 17, 2016
Run tests on Android during CI #3503
Closed

artem-zinnatullin mentioned this pull request Oct 8, 2016
Run all RxJava tests on Android to see that ProGuard rules covers all cases! artem-zinnatullin/RxJavaProGuardRules#4
Open

Uh oh!

Conversation

artem-zinnatullin commented Nov 13, 2015

Uh oh!

JakeWhartonNov 13, 2015

Choose a reason for hiding this comment

Uh oh!

artem-zinnatullinNov 13, 2015

Choose a reason for hiding this comment

Uh oh!

JakeWhartonNov 13, 2015

Choose a reason for hiding this comment

Uh oh!

artem-zinnatullinNov 13, 2015

Choose a reason for hiding this comment

Uh oh!

akarnokd commented Nov 13, 2015

Uh oh!

artem-zinnatullin commented Nov 13, 2015

Uh oh!

artem-zinnatullin commented Nov 15, 2015

Uh oh!

akarnokdNov 17, 2015

Choose a reason for hiding this comment

Uh oh!

akarnokd commented Nov 22, 2015

Uh oh!

artem-zinnatullin commented Nov 22, 2015

Uh oh!

avram commented Feb 3, 2016

Uh oh!

artem-zinnatullin commented Feb 3, 2016

Uh oh!

akarnokd commented Jun 17, 2016

Uh oh!

artem-zinnatullin commented Jun 17, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants