Uh oh!
There was an error while loading. Please reload this page.
docs(operators): add documentation for mergeMap - #201
Conversation
Codecov Report
@@ Coverage Diff @@## master #201 +/- ##
=======================================
Coverage 77.14% 77.14% =======================================
Files 15 15 Lines 175 175 Branches 7 7 =======================================
Hits 135 135 Misses 40 40Continue to review full report at Codecov.
|
btroncone
left a comment
There was a problem hiding this comment.
Looks good, just a few small updates. 👍
| 'operatorType': 'transformation' | ||
| name: 'mergeMap', | ||
| operatorType: 'transformation', | ||
| signature: `public mergeMap(project: function(value: T, ?index: number): ObservableInput, |
There was a problem hiding this comment.
Think index may be messed up here ?index: number.
There was a problem hiding this comment.
@sumitarora I just meant the signature looks off mergeMap(project: function(value: T, ?index: number), should the ? be there?
| { | ||
| type: 'Tip', | ||
| text: | ||
| 'Maps each value to an Observable, then flattens all of these inner Observables using mergeAll.' |
There was a problem hiding this comment.
Can we add a link to mergeAll?
rxjs-bot
commented
Jan 9, 2018
Generated by 🚫 dangerJS |
ashwin-sureshkumar
commented
Jan 25, 2018
@btroncone - Could you please re-review this one ? |
| name: | ||
| 'Map and flatten each letter to an Observable ticking every 1 second', | ||
| code: ` | ||
| const letters = Rx.Observable.of('a', 'b', 'c'); |
There was a problem hiding this comment.
Can you please update it to ES6 imports and pipeable operators?
| 'operatorType': 'transformation' | ||
| name: 'mergeMap', | ||
| operatorType: 'transformation', | ||
| signature: `public mergeMap(project: function(value: T, ?index: number): ObservableInput, |
There was a problem hiding this comment.
it should be index?: number if it is optional but as per source IDTS.
Closes: #119