Uh oh!
There was an error while loading. Please reload this page.
docs(operators): add documentation for sample & sampleTime - #207
docs(operators): add documentation for sample & sampleTime#207hardikpthv wants to merge 22 commits into
Conversation
Codecov Report
@@ Coverage Diff @@## master #207 +/- ##
==========================================
+ Coverage 90.78% 90.82% +0.04%
==========================================
Files 116 117 +1 Lines 445 447 +2 Branches 9 9 ==========================================
+ Hits 404 406 +2
Misses 40 40 Partials 1 1
Continue to review full report at Codecov.
|
btroncone
left a comment
There was a problem hiding this comment.
Looks great, just one small change. Thanks for the PR! 👍
| extras: [ | ||
| { | ||
| type: 'Tip', | ||
| text: `It's like sampleTime, but samples whenever the notifier Observable emits something.` |
There was a problem hiding this comment.
Can we add a link here to sampleTime?
| `, | ||
| externalLink: { | ||
| platform: 'JSBin', | ||
| url: 'http://jsbin.com/xapiviz/edit?js,console,output' |
There was a problem hiding this comment.
Please use embedded instead of edit.
There was a problem hiding this comment.
Oops! Yeah of course.
| `, | ||
| externalLink: { | ||
| platform: 'JSBin', | ||
| url: 'http://jsbin.com/hohulon/edit?js,console,output' |
ashwin-sureshkumar
commented
Dec 15, 2017
@hardikpthv - awesome job !! Please make sure there is a single operator per PR. Easier to organize and track. Also there is already a PR for sample. I will close it. Let's make sure we don't repeat work :) |
hardikpthv
commented
Dec 15, 2017
Oh i see! @ashwin-sureshkumar I will keep it in mind. :) |
ashwin-sureshkumar
commented
Dec 21, 2017
@sumitarora@btroncone - Can you please re-review this PR? |
# Conflicts: # src/operator-docs/filtering/sample.ts
# Conflicts: # src/app/team/team.service.ts
ashwin-sureshkumar
commented
Jan 12, 2018
@btroncone@sumitarora - please re-review when get a chance |
ashwin-sureshkumar
commented
Jan 25, 2018
@btroncone@sumitarora - please re-review when get a chance |
ashwin-sureshkumar
commented
Feb 2, 2018
@btroncone@sumitarora - please re-review when get a chance |
| name: 'sampleTime', | ||
| operatorType: 'filtering', | ||
| signature: | ||
| 'public sampleTime(period: number, scheduler: Scheduler): Observable<T>', |
| { | ||
| name: 'Every second, emit the most recent click at most once', | ||
| code: ` | ||
| const clicks = Rx.Observable.fromEvent(document, 'click'); |
There was a problem hiding this comment.
Update it to ES6 imports
| code: ` | ||
| const clicks = Rx.Observable.fromEvent(document, 'click'); | ||
| const result = clicks.sampleTime(1000); | ||
| result.subscribe(x => console.log(x)); |
There was a problem hiding this comment.
@hardikpthv I'm a bit confused :D will you take care of your comments in this pr :D
hardikpthv
commented
Apr 1, 2018
I think sample operator can be ignored as it's already there. |
hardikpthv
commented
Apr 14, 2018
can this be merged @ashwin-sureshkumar or any changes expected? |
Closes: #192