Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

chore(tooling): Add prettier, lint-staged and precommit hook for tooling - #49

Merged
ladyleet merged 1 commit into
ReactiveX:masterfrom
ashwin-sureshkumar:issue-45
Oct 21, 2017
Merged

chore(tooling): Add prettier, lint-staged and precommit hook for tooling#49
ladyleet merged 1 commit into
ReactiveX:masterfrom
ashwin-sureshkumar:issue-45

Conversation

@ashwin-sureshkumar

@ashwin-sureshkumar ashwin-sureshkumar commented Oct 19, 2017

Copy link
Copy Markdown
Collaborator
  • Added basic tooling configuration for linting using prettier, tslint.
  • Added precommit to run lint on staged files

Close #45

@ashwin-sureshkumar

ashwin-sureshkumar commented Oct 19, 2017

Copy link
Copy Markdown
Collaborator Author

cc @kwonoj

@ladyleet

ladyleet commented Oct 20, 2017

Copy link
Copy Markdown
Member

LGTM. @kwonoj ? (Thx @ashwin-sureshkumar )

@athomann

athomann commented Oct 20, 2017

Copy link
Copy Markdown

Would it sense to run the tests in the pre-commit hook?

@ashwin-sureshkumar

ashwin-sureshkumar commented Oct 20, 2017

Copy link
Copy Markdown
Collaborator Author

@athomann - There is a discussion about the same in the issue #45

@kwonoj

kwonoj commented Oct 20, 2017

Copy link
Copy Markdown
Member

Would it sense to run the tests in the pre-commit hook?

No. Commit occurs quite frequent and commit chunk can create test failures will make daily flow painful.

@ladyleet

ladyleet commented Oct 21, 2017

Copy link
Copy Markdown
Member

@ashwin-sureshkumar can you update the branch pls?

@ashwin-sureshkumar
chore(tooling): Add prettier, lint-staged and precommit hook for tooling
99b382b 
- Added basic tooling configuration for linting using prettier, tslint.
- Added precommit to run lint on staged files

Close ReactiveX#45
@ashwin-sureshkumar

ashwin-sureshkumar commented Oct 21, 2017

Copy link
Copy Markdown
Collaborator Author

@ladyleet - Done !

@ladyleet
ladyleet merged commit b78856e into ReactiveX:master Oct 21, 2017
@ladyleet

ladyleet commented Oct 21, 2017

Copy link
Copy Markdown
Member

@ashwin-sureshkumar 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ladyleet ladyleet ladyleet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ashwin-sureshkumar @ladyleet @athomann @kwonoj