Skip to content

fix(race): better typings - #4643

Merged
benlesh merged 1 commit into
ReactiveX:masterfrom
benlesh:race-fix-typings
Mar 15, 2019
Merged

fix(race): better typings#4643
benlesh merged 1 commit into
ReactiveX:masterfrom
benlesh:race-fix-typings

Conversation

@benlesh

@benleshbenlesh commented Mar 15, 2019

Copy link
Copy Markdown
Member
  • Actually accept other ObservableInput types (Promises, etc)
  • Fixes issue where TypeScript would complain when you tried to subscribe to a race between to Observable types.

Fixes#4390
Fixes#4642

@benlesh
fix(race): better typings
a3630e1
- Actually accept other `ObservableInput` types (Promises, etc)
- Fixes issue where TypeScript would complain when you tried to subscribe to a race between to Observable types.
FixesReactiveX#4390FixesReactiveX#4642
@benlesh
benlesh requested review from cartant and removed request for cartantMarch 15, 2019 06:37
@coveralls

coveralls commented Mar 15, 2019

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8233

  • 1 of 1(100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.962%
TotalsCoverage Status
Change from base Build 8229:0.0%
Covered Lines:5777
Relevant Lines:5958
💛 - Coveralls

@benlesh
benlesh merged commit fb9bc48 into ReactiveX:masterMar 15, 2019
@locklockBot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kwonojkwonojkwonoj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

race typings broken for mixed observable types in 6.4.0 Typing of the race operator

3 participants

@benlesh@coveralls@kwonoj