Skip to content

Extended Account Management - #69

Draft
SimonFlapse wants to merge 5 commits into
Refactorio:developfrom
SimonFlapse:ExtendedAccountManagement
Draft

Extended Account Management#69
SimonFlapse wants to merge 5 commits into
Refactorio:developfrom
SimonFlapse:ExtendedAccountManagement

Conversation

@SimonFlapse

@SimonFlapseSimonFlapse commented Jun 1, 2020

Copy link
Copy Markdown
Member

Added new Create Account page

Added new WebAccountManager service to handle all account actions across the upcoming account pages

closes#68

@SimonFlapse
Added create account page
2dba037
Added new WebAccountManager service to handle all account actions across the upcoming account pages
@SimonFlapse
Added navbar link to create account for root users
97cd132
@grilledham

grilledham commented Jun 1, 2020

Copy link
Copy Markdown
Contributor

More good work!
It would be nice to be able to view all accounts, or is that planned as another PR?

grilledham
grilledham reviewed Jun 1, 2020
View reviewed changes
Comment threadFactorioWebInterface/Pages/Admin/CreateAccount.cshtml.cs Outdated
grilledham
grilledham reviewed Jun 1, 2020
View reviewed changes
Comment threadFactorioWebInterface/Pages/Admin/CreateAccount.cshtml.cs Outdated
grilledham
grilledham reviewed Jun 1, 2020
View reviewed changes
Comment threadFactorioWebInterface/Pages/Admin/CreateAccount.cshtml.cs Outdated
grilledham
grilledham reviewed Jun 1, 2020
View reviewed changes
Comment threadFactorioWebInterface/Services/WebAccountManager.cs Outdated
grilledham
grilledham reviewed Jun 1, 2020
View reviewed changes
Comment threadFactorioWebInterface/Services/WebAccountManager.cs Outdated
@SimonFlapse

SimonFlapse commented Jun 1, 2020

Copy link
Copy Markdown
MemberAuthor

More good work!
It would be nice to be able to view all accounts, or is that planned as another PR?

I marked it as a draft pr, because I planned on adding all the features from #68 I just haven't had the time to finish it up.

I haven't really decided how general account management should look like.

@grilledham

grilledham commented Jun 1, 2020

Copy link
Copy Markdown
Contributor

Cool, that makes sense.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grilledhamgrilledhamgrilledham left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extended account management

2 participants

@SimonFlapse@grilledham