Conversation
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 83.41% 83.32% -0.09%
==========================================
Files 1821 1820 -1
Lines 185725 170881 -14844
==========================================
- Hits 154914 142393 -12521
+ Misses 30811 28488 -2323
Continue to review full report at Codecov.
|
langou
reviewed
Apr 6, 2021
weslleyspereira
force-pushed
the
fix-411-div-by-zero-in-CTGSJA
branch
from
April 7, 2021 00:10
177938c to
5d5286e
Compare
weslleyspereira
force-pushed
the
fix-411-div-by-zero-in-CTGSJA
branch
from
April 7, 2021 00:16
5d5286e to
5a7bde2
Compare
langou
self-requested a review
April 7, 2021 02:15
Collaborator
Author
|
Using PR #493 and the test case from #411 (comment), we obtain a NaN in the output although INFO=0:
My last commit tries to improve the readability of my changes. |
langou
approved these changes
Apr 7, 2021
christoph-conrads
pushed a commit
to christoph-conrads/lapack
that referenced
this pull request
May 23, 2021
…div-by-zero-in-CTGSJA Fix 411 div by zero in ctgsja
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #411
This PR replaces
A1.NE.ZEROwithGAMMA is finitein the subroutines xTGSJA.