Skip to content

Fix 411 div by zero in ctgsja - #502

Merged
langou merged 3 commits into
Reference-LAPACK:masterfrom
weslleyspereira:fix-411-div-by-zero-in-CTGSJA
Apr 7, 2021
Merged

langou merged 3 commits into
Reference-LAPACK:masterfrom
weslleyspereira:fix-411-div-by-zero-in-CTGSJA

Conversation

@weslleyspereira

@weslleyspereira weslleyspereira commented Mar 2, 2021

Copy link
Copy Markdown
Collaborator

Closes #411

This PR replaces A1.NE.ZERO with GAMMA is finite in the subroutines xTGSJA.

@codecov

codecov Bot commented Mar 2, 2021

Copy link
Copy Markdown

Codecov Report

Merging #502 (177938c) into master (d71dd6e) will decrease coverage by 0.08%.
The diff coverage is 86.44%.

❗ Current head 177938c differs from pull request most recent head 5a7bde2. Consider uploading reports for the commit 5a7bde2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
- Coverage   83.41%   83.32%   -0.09%     
==========================================
  Files        1821     1820       -1     
  Lines      185725   170881   -14844     
==========================================
- Hits       154914   142393   -12521     
+ Misses      30811    28488    -2323     
Impacted Files Coverage Δ
SRC/stgsja.f 91.33% <85.71%> (-1.90%) ⬇️
SRC/ctgsja.f 91.72% <86.66%> (-1.75%) ⬇️
SRC/dtgsja.f 91.33% <86.66%> (-1.90%) ⬇️
SRC/ztgsja.f 91.72% <86.66%> (-1.75%) ⬇️
SRC/zggsvd3.f 89.70% <0.00%> (-7.36%) ⬇️
SRC/dlaqr1.f 47.61% <0.00%> (-6.23%) ⬇️
SRC/slaqr1.f 47.61% <0.00%> (-6.23%) ⬇️
SRC/dlals0.f 74.73% <0.00%> (-4.76%) ⬇️
SRC/slals0.f 74.73% <0.00%> (-4.76%) ⬇️
SRC/chegst.f 86.44% <0.00%> (-4.58%) ⬇️
... and 1819 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b07c5e...5a7bde2. Read the comment docs.

@langou langou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ reverting my comment ]

@weslleyspereira
weslleyspereira force-pushed the fix-411-div-by-zero-in-CTGSJA branch from 177938c to 5d5286e Compare April 7, 2021 00:10
@weslleyspereira
weslleyspereira force-pushed the fix-411-div-by-zero-in-CTGSJA branch from 5d5286e to 5a7bde2 Compare April 7, 2021 00:16
@langou
langou self-requested a review April 7, 2021 02:15
@weslleyspereira

Copy link
Copy Markdown
Collaborator Author

Using PR #493 and the test case from #411 (comment), we obtain a NaN in the output although INFO=0:

 INFO =            0
 K =            0
 L =            6
 ALPHA:    2.73536585E-15   1.48088933E-27   1.57898426E-33   0.00000000       0.00000000       0.00000000    
 BETA:     1.00000000       1.00000000       1.00000000                  NaN   1.00000000       1.00000000
  1. With the solution from this PR (Fix 411 div by zero in ctgsja #502), I obtain:
 INFO =            0
 K =            0
 L =            6
 ALPHA:    2.73536606E-15   1.48088913E-27   1.57898444E-33   0.00000000       0.00000000       0.00000000    
 BETA:     1.00000000       1.00000000       1.00000000       1.00000000       1.00000000       1.00000000

My last commit tries to improve the readability of my changes.

@langou
langou merged commit 5472d5e into Reference-LAPACK:master Apr 7, 2021
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this pull request May 23, 2021
…div-by-zero-in-CTGSJA

Fix 411 div by zero in ctgsja
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dead-lock in SLARTG called by CTGSJA

2 participants