comments fixed: synced with code in xGTT02 (#3 from PR#562 discussion) - #566
Merged
Merged
Conversation
…R#562) Comments in xGTT02 declared that it uses norm(A) but its code implemented 1-norm of op(A).
Codecov Report
@@ Coverage Diff @@
## master #566 +/- ##
=======================================
Coverage 82.37% 82.37%
=======================================
Files 1894 1894
Lines 190677 190677
=======================================
Hits 157063 157063
Misses 33614 33614 Continue to review full report at Codecov.
|
langou
approved these changes
May 24, 2021
weslleyspereira
approved these changes
May 24, 2021
weslleyspereira
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @jip!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments in xGTT02 declared that it uses norm(A) but its code implemented 1-norm of op(A).