Uh oh!
There was an error while loading. Please reload this page.
docs(review): apply Tristan's two must-fix items from the final review - #97
Conversation
Greptile SummaryThis PR applies two accuracy fixes identified in a final review: aligning the SIWE message example in the wallet-authentication docs with actual server output, and adding a payment-destination prerequisite to the Client ID generation steps.
Confidence Score: 5/5Safe to merge — both changes are documentation-only accuracy corrections with no functional code impact. Both files contain only documentation text changes. The SIWE message update brings the example into sync with the real server output (period, no Chain ID, Expiration Time field), and the getting-started update adds a clearly missing prerequisite step that prevents user confusion at the dashboard. Neither change introduces incorrect information or breaks any existing guidance. No files require special attention. The top-level Quick Setup Steps block in getting-started.mdx still omits the payment-destination prerequisite, but this was flagged in a prior review and does not block this PR. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant Dashboard
participant AuthAPI as auth.request.network
participant Wallet
User->>Dashboard: Sign up / Log in
User->>Dashboard: Set up payment destination
Dashboard-->>User: Destination created (Client IDs section now visible)
User->>Dashboard: Open Manage Destination → Client IDs
User->>Dashboard: Click "Generate your first Client ID"
Dashboard-->>User: Client ID issued
Note over User,AuthAPI: Wallet Auth (SIWE) Flow
User->>AuthAPI: "POST /v1/auth/wallet/challenge {address}"
AuthAPI-->>User: "{challengeId, nonce, message, expiresAt}"
Note right of AuthAPI: message includes: Sign in to Request Network. No Chain ID field. Expiration Time = expiresAt
User->>Wallet: Sign message
Wallet-->>User: signature
User->>AuthAPI: "POST /v1/auth/wallet/verify {challengeId, nonce, message, signature}"
AuthAPI-->>User: httpOnly session cookie
Reviews (2): Last reviewed commit: "docs(review): apply Tristan's two must-f..." | Re-trigger Greptile |
MantisClone
left a comment
There was a problem hiding this comment.
LGTM. SIWE fix matches the server template exactly (period present, no Chain ID line, Expiration Time set 5 min after Issued At = matches existing expiresAt two lines below). getting-started Client ID Generation flow now reflects the actual Dashboard UI: destination-creation prerequisite + both button labels with their conditions. Verified against request-auth-api/src/auth/auth.service.ts:187-196 and request-dashboard/src/pages/ManageDestination/blocks/ClientIdsSection.tsx:107-129. Ready to ship.
Merge activity
|
(1) api-reference/wallet-authentication.mdx — SIWE message example now matches the actual server output from request-auth-api/auth.service.ts: - "Sign in to Request Network" → "Sign in to Request Network." (period per the source string) - Dropped the "Chain ID: 1" line (the server does not emit it) - Added "Expiration Time: <iso>" line (the server emits it after Issued At; used the same value the docs already show for `expiresAt`) (2) api-setup/getting-started.mdx — Client ID Generation steps - Added a prerequisite step pointing users to create a payment destination first, because the Client IDs section is only visible once a destination exists. - Empty-state button labelled "Generate your first Client ID" (the actual dashboard label for the first-Client-ID case, per ManageDestination/blocks/ClientIdsSection.tsx). "Generate New Client ID" is still mentioned as the post-first-creation label.
e3188be to
955e887CompareUh oh!
There was an error while loading. Please reload this page.
(1) api-reference/wallet-authentication.mdx — SIWE message example now
matches the actual server output from request-auth-api/auth.service.ts:
per the source string)
At; used the same value the docs already show for
expiresAt)(2) api-setup/getting-started.mdx — Client ID Generation steps
destination first, because the Client IDs section is only visible
once a destination exists.
actual dashboard label for the first-Client-ID case, per
ManageDestination/blocks/ClientIdsSection.tsx). "Generate New Client
ID" is still mentioned as the post-first-creation label.