Uh oh!
There was an error while loading. Please reload this page.
feat: tombchain - #1024
Merged
Merged
Conversation
leoslr
marked this pull request as ready for review
December 22, 2022 14:05
github-actionsBot
requested review from
KolevDarko, alexandre-abrioux and benjlevesqueDecember 22, 2022 14:05
benjlevesque
approved these changes
Dec 22, 2022
alexandre-abrioux
approved these changes
Dec 22, 2022
Contributor
There was a problem hiding this comment.
@leoslr FYI this is how it's done for the storage to detect if it can use EIP-1559:
requestNetwork/packages/ethereum-storage/src/ethereum-tx-submitter.ts
Lines 35 to 42 in 0af020b
It could be extracted into an util function
leoslr
commented
Dec 22, 2022
ContributorAuthor
@alexandre-abrioux I won't add it to this PR to keep what's related to contract deployment clean. I'll add myself a ticket to do it in the next weeks |
alexandre-abrioux
commented
Dec 22, 2022
Contributor
marcohefti pushed a commit
to marcohefti/requestNetwork
that referenced
this pull request
Jan 3, 2023
marcohefti pushed a commit
to marcohefti/requestNetwork
that referenced
this pull request
Jan 3, 2023
MantisClone added a commit
that referenced
this pull request
Jan 17, 2023
* Replace default export with named exports in utils package to enable tree shaking (fixes#1015) This change replaces the default export in the utils package with named exports, which allows for better tree shaking and smaller build sizes in user code applications. It also enforces the no-default-export ESLint rule to ensure consistent code style * running refactored files through prehook (#1015) * Apply changes to utils package to monorepo This commit applies the changes made to the utils package to the rest of the monorepo. The changes include replacing the default export with named exports and enforcing the no-default-export ESLint rule. NOTE: Not all changes could be tested (#1029, #1030, #1031) * Apply changes to utils package to payment-processor/test/payment/any-to-near.test.ts * feat: tombchain (#1024) * feat: tombchain (#1024) * running refactored files through prehook (#1015) * Apply changes to utils package to monorepo This commit applies the changes made to the utils package to the rest of the monorepo. The changes include replacing the default export with named exports and enforcing the no-default-export ESLint rule. NOTE: Not all changes could be tested (#1029, #1030, #1031) * Apply changes to utils package to payment-processor/test/payment/any-to-near.test.ts * fix circular dependency by importing from the corresponding package rather from the same package barrel file * Resolves#1023: Rename ambiguous functions for clarity As discussed with @alexandre-abrioux and @benjlevesque, many of the functions in the utils module have been refactored and need to be renamed for improved code readability. Signed-off-by: marcohefti <marco@heftiweb.ch> * Fix README, identity, and signature file updates -Removed list of utils from README to avoid staleness -Changed 'hasError' to 'identityHasError' -Changed 'sign' back to original name 'sign' -Changed 'recover' to 'recoverSigner' Addressed comments by @MantisClone Signed-off-by: marcohefti <marco@heftiweb.ch> * Refactor crypto and ec-utils modules -Removed the named const from crypto-wrapper.ts and exported functions individually -Removed the named const from ec-utils.ts and exported functions individually -Renamed recover() to recoverSigner() in ec-utils.ts -Prefixed functions with 'ec' to prevent duplicate variables -Reverted normalizeData() to normalize() Signed-off-by: marcohefti <marco@heftiweb.ch> Signed-off-by: marcohefti <marco@heftiweb.ch> Co-authored-by: MantisClone <david.huntmateo@request.network> Co-authored-by: leoslr <50319677+leoslr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
Tombchain is a permissioned L2 evm.
Deployments: only
ERC20FeeProxyandEthFeeProxy.https://app.asana.com/0/1203350802794948/1203600402430063
Additional fix:
When making the deployment, I was blocked as the Tombchain Node RPC did not support the eth_FeeHistory method used by the eip1559.
All evm nodes may not support it yet. It does not block the deployment anymore