Uh oh!
There was an error while loading. Please reload this page.
chore: enforce eslint monorepo/no-relative-import rule - #1200
Merged
Conversation
MantisClone
marked this pull request as ready for review
October 16, 2023 12:51
github-actionsBot
requested review from
KolevDarko, alexandre-abrioux, benjlevesque and olivier7delfOctober 16, 2023 12:51
| "devDependencies": { | ||
| "@types/jest": "26.0.13", | ||
| "@types/lodash": "4.14.161", | ||
| "eslint-plugin-monorepo": "0.3.2", |
Contributor
There was a problem hiding this comment.
Should we install it in the main package.json instead? See other plugins here:
Line 42 in cc56640
alexandre-abrioux
approved these changes
Oct 16, 2023
alexandre-abrioux
left a comment
Contributor
There was a problem hiding this comment.
Just a comment regarding the installation's location, other than that LGTM 🙂
KolevDarko
approved these changes
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes