Uh oh!
There was an error while loading. Please reload this page.
Implementation of RCML Java Builder SDK. - #23
Conversation
jaimecasero
commented
Nov 20, 2017
please ignore target dir to prevent .class files to go into SCM |
rlimonta
commented
Nov 24, 2017
@jaimecasero We have a /target/ dir on .gitignore file |
gsaslis
left a comment
There was a problem hiding this comment.
Hi @rlimonta !
Thanks for taking the time to contribute this!
Could I please ask for some changes, so that we can make this easier to review and therefore give it a higher chance of getting it merged?
- Let's try to separate the commits that delete the
.classand other maven artifact files undertargetin another PR, as a kind of hotfix. This should be dead simple for us to merge. - If you could then cherry-pick the rest into a separate PR.
- Could you also include some documentation (maybe a couple of lines in the README.md about what this PR adds to the SDK ?
As a final note, I'd also point out that writing more meaningful commit messages (that explain the why, not the what ), really shows some <3 to the person reviewing your code, so it also means they'll more happily spend their time going through your PR and merging it in. ; )
Thanks in advance!
Example of using the RCML library.
rlimonta
commented
Dec 22, 2017
@jaimecasero and @gsaslis I implemented the requested improvements. Best regards! |
gsaslis
commented
Feb 6, 2018
@rlimonta thanks for the extra work on this and adding some docs. Are you also planning to proceed with my suggestion to split this PR into 2 separate ones? |
No description provided.