Conversation
- ydkjs-sc（作用域和閉包）、ydkjs-tp（this和物件原型）、ydkjs-tg（類型和語法）、 ydkjs-ap（異步和性能）、ydkjs-ug（起步上路）、ydkjs-es6（ES6及更新版本） 六章題目全部完成，每題程式碼片段皆以 node 實測後才寫入，並通過 validate-questions.mjs／tsc／next build 驗證 - 新增 packages/core 的 Topic 抽象（types.ts + data/topics.ts）， 首頁單一書籍卡片點入後先看到章節列表，再進入關卡列表（web + mobile 同步） Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Warning Review limit reached
Next review available in:18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthroughAdds grouped topic data and topic chapter navigation to the web and mobile apps. The core package gains six YDKJS chapters and numerous structured question datasets covering scope, types, objects, asynchronous JavaScript, ES6, and introductory programming concepts. ChangesTopic learning flow
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Home
participant TopicBooks
participant LevelList
participant Progress
Home->>TopicBooks: open grouped topic
TopicBooks->>Progress: read completed levels
TopicBooks->>LevelList: open selected chapter
LevelList->>TopicBooks: return for grouped chapter
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 13
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/core/src/data/questions/ydkjs-ap-1-async-now-and-later.json`:
- Around line 120-137: 修正題目 ydkjs-ap-1-q6 的選項 a 與
explanation，將「非阻塞」限定為瀏覽器／Node.js 提供的特定非同步 API（如計時器、網路請求），並明確保留同步程式碼、CPU 密集型
JavaScript 與同步 Node I/O 會占用事件迴圈；不要將非阻塞描述成 JavaScript 本身的普遍特性。
In `@packages/core/src/data/questions/ydkjs-ap-2-callbacks.json`:
- Line 36: Update the cache-hit condition in the getData examples to check cache
membership with hasOwnProperty rather than cached-value truthiness, preserving
cached 0, false, and empty-string values. Apply this at
packages/core/src/data/questions/ydkjs-ap-2-callbacks.json lines 36-36, 59-59,
and 82-82.
In `@packages/core/src/data/questions/ydkjs-ap-5-program-performance.json`:
- Around line 9-21: Revise the Web Worker explanations in
packages/core/src/data/questions/ydkjs-ap-5-program-performance.json at lines
9-21, 28-40, 47-59, and 116-128: retain that ordinary variables are isolated,
but clarify that SharedArrayBuffer with Atomics enables intentional shared
memory; describe postMessage/message as the normal, not exclusive, communication
mechanism; and distinguish structured cloning from transferable ownership for
ArrayBuffer, MessagePort, and ImageBitmap. Update the corresponding options,
answers, and explanations consistently.
In `@packages/core/src/data/questions/ydkjs-ap-7-advanced-async.json`:
- Around line 120-132: Update the question’s option a and its explanation so
they no longer claim observables share a generator-based foundation: state that
iterable sequences and generator coroutines use generator mechanisms, while
observables use a separate closure/listener-based multi-value event pattern.
Preserve the distinction that all three address limitations of Promise, but
avoid describing them as one shared implementation or foundation.
In `@packages/core/src/data/questions/ydkjs-es6-1-now-and-future.json`:
- Around line 93-110: 更新題目與解釋中對 TC39 階段的描述：明確指出 Stage 0 才是最早期階段，並將 Stage 4
描述為提案已定案、將納入正式規範，不要限定為「下一版」規範。同步檢查 prompt、選項 a、explanation 與
verify.manual，保留其餘關於早期提案風險的內容。
In `@packages/core/src/data/questions/ydkjs-es6-4-async-flow-control.json`:
- Around line 74-95: Update the run function’s step error handling to use an
explicit resume mode rather than the truthiness of err, so rejected Promises
with 0, false, empty string, null, or undefined invoke it.throw and reach the
generator’s catch block. Preserve it.next for successful resolutions and pass
the mode through both Promise callbacks.
- Around line 120-137: Update the explanation in question “ydkjs-es6-4-q6” to
describe async/await as a conceptual analogue to the generator-plus-driver
pattern, not literal generator syntax sugar. Clarify that async functions return
Promises and use native await suspension, whereas generators expose
next()/throw() and iterator objects; retain the comparison of their similar
control flow without claiming they are the same mechanism.
In `@packages/core/src/data/questions/ydkjs-es6-5-collections.json`:
- Around line 120-140: Update the WeakMap question’s topic and explanation to
state that keys may be objects or non-registered Symbols, while primitive
strings and numbers remain invalid. Preserve the existing string-key example,
answer, and verification output, and adjust only the descriptions that
incorrectly claim keys must always be objects.
In `@packages/core/src/data/questions/ydkjs-es6-6-new-apis.json`:
- Around line 120-140: Update the explanation for question “ydkjs-es6-6-q6” to
define Number.EPSILON as the gap between 1 and the next representable Number,
not a universal floating-point tolerance. Preserve the current example’s
false/true result, but state that larger magnitudes require a magnitude-aware or
domain-specific tolerance, using values such as 1000.1 + 1000.2 versus 2000.3 as
the boundary example.
In `@packages/core/src/data/questions/ydkjs-sc-5-closures.json`:
- Line 90: Update the explanation in the relevant YDKJS question entry to
replace the stale “jsa-2-q8” cross-reference with the correct dataset question
ID for the let-based solution, or remove the cross-reference if no matching
target exists. Preserve the rest of the explanation unchanged.
In `@packages/core/src/data/questions/ydkjs-tg-1-types.json`:
- Around line 127-136: Update the explanation for answer option “a” and the
corresponding “explanation” field to scope typeof’s no-throw safety specifically
to unresolvable or undeclared identifiers. Remove the claim that it is safe for
any input, and do not imply that let/const bindings in their temporal dead zone
are handled safely; preserve the existing null caveat and overall rationale.
In `@packages/core/src/data/questions/ydkjs-tg-3-native-functions.json`:
- Line 9: Update the topic text in the native-functions entry to avoid claiming
that Object.prototype.toString.call precisely determines types or reads an
internal [[Class]] marker. Reword it to describe the result as built-in tags, or
the tags returned for these values, while preserving the existing explanation’s
scope.
In `@packages/core/src/data/questions/ydkjs-ug-3-series-overview.json`:
- Line 13: Update the arrow-function example and its expected answer to describe
lexical this as the surrounding CommonJS module context (module.exports), not
the global object. Keep the regular method’s this behavior unchanged and ensure
the explanation reflects that this.name resolves to undefined from that binding.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 5a4f6ed1-ae65-4dd9-a37b-2cd050668de5
📒 Files selected for processing (47)
apps/mobile/app/(tabs)/index.tsxapps/mobile/screens/Home.tsxapps/mobile/screens/TopicBooks.tsxapps/web/src/App.tsxapps/web/src/screens/Home.tsxapps/web/src/screens/TopicBooks.tsxpackages/core/src/data/chapters.tspackages/core/src/data/questions/ydkjs-ap-1-async-now-and-later.jsonpackages/core/src/data/questions/ydkjs-ap-2-callbacks.jsonpackages/core/src/data/questions/ydkjs-ap-3-promises.jsonpackages/core/src/data/questions/ydkjs-ap-4-generators.jsonpackages/core/src/data/questions/ydkjs-ap-5-program-performance.jsonpackages/core/src/data/questions/ydkjs-ap-6-benchmarking-tuning.jsonpackages/core/src/data/questions/ydkjs-ap-7-advanced-async.jsonpackages/core/src/data/questions/ydkjs-es6-1-now-and-future.jsonpackages/core/src/data/questions/ydkjs-es6-2-syntax.jsonpackages/core/src/data/questions/ydkjs-es6-3-code-organization.jsonpackages/core/src/data/questions/ydkjs-es6-4-async-flow-control.jsonpackages/core/src/data/questions/ydkjs-es6-5-collections.jsonpackages/core/src/data/questions/ydkjs-es6-6-new-apis.jsonpackages/core/src/data/questions/ydkjs-es6-7-metaprogramming.jsonpackages/core/src/data/questions/ydkjs-es6-8-beyond-es6.jsonpackages/core/src/data/questions/ydkjs-sc-1-what-is-scope.jsonpackages/core/src/data/questions/ydkjs-sc-2-lexical-scope.jsonpackages/core/src/data/questions/ydkjs-sc-3-function-block-scope.jsonpackages/core/src/data/questions/ydkjs-sc-4-hoisting.jsonpackages/core/src/data/questions/ydkjs-sc-5-closures.jsonpackages/core/src/data/questions/ydkjs-sc-6-dynamic-scope.jsonpackages/core/src/data/questions/ydkjs-sc-7-block-scope-alternatives.jsonpackages/core/src/data/questions/ydkjs-tg-1-types.jsonpackages/core/src/data/questions/ydkjs-tg-2-values.jsonpackages/core/src/data/questions/ydkjs-tg-3-native-functions.jsonpackages/core/src/data/questions/ydkjs-tg-4-coercion.jsonpackages/core/src/data/questions/ydkjs-tg-5-syntax.jsonpackages/core/src/data/questions/ydkjs-tp-1-about-this.jsonpackages/core/src/data/questions/ydkjs-tp-2-this-all-explained.jsonpackages/core/src/data/questions/ydkjs-tp-3-objects.jsonpackages/core/src/data/questions/ydkjs-tp-4-mixing-objects-classes.jsonpackages/core/src/data/questions/ydkjs-tp-5-prototypes.jsonpackages/core/src/data/questions/ydkjs-tp-6-behavior-delegation.jsonpackages/core/src/data/questions/ydkjs-tp-7-es6-class.jsonpackages/core/src/data/questions/ydkjs-ug-1-into-programming.jsonpackages/core/src/data/questions/ydkjs-ug-2-into-javascript.jsonpackages/core/src/data/questions/ydkjs-ug-3-series-overview.jsonpackages/core/src/data/topics.tspackages/core/src/index.tspackages/core/src/types.ts
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- 非阻塞限定為特定瀏覽器/Node API，同步/CPU密集程式碼仍會阻塞 - 快取查詢改用 hasOwnProperty，避免誤判假值(0/false/'')為未命中 - Web Worker：補充 SharedArrayBuffer+Atomics 例外、postMessage 標準管道措辭、structured clone 與 transferable object 的差異 - 修正 observable 誤植為建立在生成器機制上的說法 - 修正 TC39 Stage 1 誤標為最早期階段（應為 Stage 0） - 修正生成器驅動函式用 err 真假值判斷、無法處理假值錯誤原因的 bug - 軟化 async/await 為生成器語法糖的說法，改為概念類比 - WeakMap key 補充 ES2023 非註冊 Symbol 的例外 - Number.EPSILON 補充僅適用於接近 1 量級數值的限制 - 修正跨檔案題目引用的錯誤標號（Q4→Q8） - typeof 安全性限定於未宣告識別字，TDZ 內的 let/const 仍會拋錯 - 軟化 Object.prototype.toString.call 讀取「內部 [[Class]] 標記」的說法 - 修正箭頭函式 this 在 Node CommonJS 模組下實為 module.exports，非全域物件 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit