Uh oh!
There was an error while loading. Please reload this page.
fix(PLU-326): stop treating failed analyses as complete in status poller - #29
Merged
akashb95 merged 1 commit intoAug 26, 2026
Conversation
**Context:** `PeriodicChecker._worker` treated any status other than `Queued`/`Processing` as a completed, successful analysis, including `Error`. That persisted the failed analysis as attached and then crashed on a downstream 422, since the backend has no function map to return for a failed analysis. **This diff:** - Branches on the real `revengai.StatusInput` enum: in-progress statuses (`Uploaded`/`Queued`/`Processing`) reschedule as before, `Complete` runs the existing success path, and anything else (`Error`, or unrecognised) is now a terminal failure that is logged via `log_error` with no callback, sync, or persistence. - Rewords the two `except` blocks' log messages, which wrap the whole worker rather than just the status check and previously mislabeled failures as "during status check". - Removes the dead, never-emitted `update_text_signal`/`_update_text_slot` Qt signal copy-pasted from an unrelated class.
akashb95
marked this pull request as ready for review
August 26, 2026 09:22
vgoat21
approved these changes
Aug 26, 2026
Uh oh!
There was an error while loading. Please reload this page.
akashb95
deleted the
plu-326-binary-ninja-analysis-always-fails-with-ghidra-binary
branch
August 26, 2026 10:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
PeriodicChecker._worker, the analysis-status poller, treated any status other thanQueued/Processingas a completed, successful analysis — includingError. That caused it to persist the failed analysis as attached and then crash on a downstream 422, since the backend has no function map to return for a failed analysis.