Skip to content

Start Luke at login - #482

Open
charleslpan wants to merge 2 commits into
mainfrom
charleslpan/discuss-plan-v1
Open

Start Luke at login#482
charleslpan wants to merge 2 commits into
mainfrom
charleslpan/discuss-plan-v1

Conversation

@charleslpan

@charleslpancharleslpan commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Start Luke at login by default on packaged macOS builds, expose the preference in Appearance, and preserve changes made in System Settings.
  • Keep unpackaged, non-macOS, fixture, and evidence runs from touching Login Items, with focused reconciliation, persistence, reset, search, and spoken-control coverage.

Evidence

  • Platform-independent checks: ./scripts/check.sh passed
  • macOS Electron verification (./scripts/verify.sh): passed

Automated visual evidence

Download the deterministic macOS evidence · workflow run

  • Commit: 8c4d5c03daa8f38af3c1c7c4bebd8000b8a92973
  • Scenario: smoke
  • Physical-notch check: not performed by CI

Physical-device evidence

  • Screenshot or screen recording: not attached
  • Physical-notch check: not performed
  • Device/display configuration: not recorded

Notes

  • Follow-up verification: confirm a first packaged launch registers Luke, the Appearance switch removes it immediately, and removal in System Settings survives relaunch.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel

vercelBot commented Aug 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
luke-webReadyReadyPreviewAug 24, 2026 7:00pm

Request Review

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8c4d5c0. Configure here.

await persist(defaultOpen);
} else if (observed !== stored) {
await persist(observed);
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirror undoes pending registration

High Severity

After the first launch spends the default (or the user turns the switch on), any later launch where macOS still reports openAtLogin as false is treated as a System Settings removal and persists false. A failed or still-pending SMAppService registration therefore wipes the stored preference, so Start at login stays off even though nobody turned it off.

Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 8c4d5c0. Configure here.

},
);
})
.catch(() => undefined);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reconcile skips settings broadcast

Medium Severity

Launch reconciliation writes startAtLogin through settingsStore.set without broadcasting settingsChanged, and the work is not awaited before panels bootstrap. If the renderer snapshots settings first, Appearance can keep showing the pre-reconcile value after System Settings was mirrored.

Fix in CursorFix in Web

Reviewed by Cursor Bugbot for commit 8c4d5c0. Configure here.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@charleslpan