Skip to content

Don't include do_task() results in the summary (fix #851) - #855

Open
kablamo wants to merge 1 commit into
masterfrom
eric/do-task-summary
Open

Don't include do_task() results in the summary (fix #851)#855
kablamo wants to merge 1 commit into
masterfrom
eric/do-task-summary

Conversation

@kablamo

Copy link
Copy Markdown
Contributor

Fix for #851

How to test

  • prove t/summary.t

@kablamokablamo added this to the 1.4.0 milestone Dec 8, 2015
@kablamokablamo added the bug Confirmed bugs label Dec 8, 2015
@krimdomu

Copy link
Copy Markdown
Contributor

Currently this crashes on my windows system (win 10, perl 5.22.0) (perl interpreter just dies)
The idea to define a parent task is nice and maybe we can extend this idea to print a tree like summary.

Also i'm not sure if we want to hide do_task calls in the summary. The difference between run_task and do_task is that run_task is used to run one task on one server to get some value in return. So the Rexfile should handle failures with this internally.

do_task on the other hand just run the task on all the defined servers so i think it is good to display those results.

@krimdomukrimdomu modified the milestones: 1.5.0, 1.4.0Dec 19, 2015
@krimdomu

Copy link
Copy Markdown
Contributor

I'm going to add this to 1.5.0 milestone, then we can think about it and how we want to display the results.

@krimdomukrimdomu modified the milestones: backlog, 1.5.0Mar 24, 2016
@ferkiferki added the ready An idea that is ready to be worked on label Mar 25, 2016
@ferkiferki removed this from the backlog milestone Mar 25, 2016
@ferkiferki removed the ready An idea that is ready to be worked on label Apr 25, 2016
@ferkiferki changed the title Don't include do_task() results in the summaryDon't include do_task() results in the summary (fix #851)Apr 25, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugConfirmed bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kablamo@krimdomu@ferki