fix: isolate Linux SteamCMD user configuration - #2421
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
LionelColaso
approved these changes
Sep 9, 2026
LionelColaso
left a comment
Member
There was a problem hiding this comment.
Nice catch looks Good Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Run Linux workshop downloads with
HOME,XDG_CONFIG_HOME, andXDG_DATA_HOMEunder a dedicatedhomedirectory inside the configured SteamCMD prefix. SteamCMD no longer inherits the desktop Steam client's user-configuration paths. Refs #2419.The first download, queued batches, and manual restart retain these overrides. Other inherited variables, including
PATH, remain available. Windows and macOS retain their existing environment. Relative prefixes resolve to absolute isolation paths before launch. User documentation describes the dedicated directory.Validation
Regression tests cover process wiring, absolute paths, relative prefixes, inherited variables, queued batches, restart, and non-Linux behavior.
uv run pytest --doctest-modules --no-qt-log -q: 1369 passed, 1 skipped.git diff --check: passed.EXE001on untouchedapp/__main__.py(its tracked file mode is not executable).These checks ran on macOS. They verify environment construction and QProcess wiring; no real Linux SteamCMD run or desktop-library preservation trial was performed. Directory-creation errors fail before the subprocess starts rather than falling back to the desktop environment.
Agent disclosure
Generated and independently reviewed by OpenAI Codex for be-student. No human review has occurred before submission; maintainer review and Linux runtime verification are requested.