fix: recover stale run coordination locks - #29
Conversation
|
Review findings fixed and pushed, one scoped commit per fix:
Validation:
|
|
CI follow-up fix pushed in 73113db ( Windows revealed that Fix:
Validation: TypeScript build passes; run-storage suites pass 37/37 locally with the one native-Windows-only test skipped; diff check clean; four independent review passes found no actionable issues. Replacement CI is now running. |
|
Final review summary — all findings fixed and pushed. Review findings and fixes:
Validation:
No existing review threads were present to reply to or resolve. PR merge state: clean. |
What changed
Why
Stale
run.lockandsession.lockfiles could permanently block run coordination after a process crash. Windows could also transiently reject replacement ofrun.json, leaving coordination updates unreliable.Closes #28.
How to test
npm run build node --import tsx --test tests/run-storage.test.ts node --import tsx --test --test-name-pattern='run message --async|CLI forwards parent signals' tests/run-coordination.test.ts tests/headless.test.ts npm run pack:check npm audit --omit=devVerification
npm run checkis currently blocked by unrelated tmux tests with fixed May 2026 transcript timestamps and an existing cleanup-duration assertion. Both failure modes reproduce on the untouchedda89badbase commit; they are not introduced by this PR.