feat: add lanelet2 - #242
Conversation
wep21
commented
Jan 10, 2025
- as title
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
|
@Tobias-Fischer need approve to run ci? |
|
@wep21 - I fixed the errors on MacOS+Linux. However, I do not have the capacity to fix the Windows issues. Please either add relevant patches yourself if you are interested, or remove the addition of lanelet2 on Windows. /cc @traversaro as our Windows expert. |
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
|
@Tobias-Fischer Thanks for the fix. I'm trying to fix the error on windows. Is there any way to trigger ci again? |
|
Seems like this didn’t work @wep21 - can you try a local build first? It’s as easy as cloning the repo and running “pixi run build” |
|
Currently, I don't have windows environment, so I'll debug with my fork repository first. |
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
Signed-off-by: wep21 <daisuke.nishimatsu1021@gmail.com>
|
@Tobias-Fischer @traversaro I've fixed the windows build error. I appreciate if you could review the patches. https://github.com/wep21/ros-humble/actions/runs/12750363858/job/35534922572?pr=3 |
Tobias-Fischer
left a comment
There was a problem hiding this comment.
LGTM - @traversaro do you want to take a look as well?
|
Seems great! @wep21 do you think it could make sense to also propose these changes upstream? It may be more work in the short term, but in the long run it removes the need to manually maintain the patches, and make the fixes available also for non-robostack users. |