Remove rosidl generator py patch

[mini-1235]

No description provided.

[mini-1235]

@wep21 I am running into a similar issue to RoboStack/ros-lyrical#5 while testing Nav2. I asked my AI to dig into the root cause, and this seems to be the issue (I haven't fully validated it yet, but it looks reasonable to me)

Do you remember what issues you were running into that led us to introduce this patch in the first place?

[wep21]

This comes from upstream PR.
cc @traversaro

[mini-1235]

Thanks for pointing me to the PR. That seems like the issue, perhaps I should update it similar to what we have in the kilted repo?

[traversaro]

@wep21 I am running into a similar issue to RoboStack/ros-lyrical#5 while testing Nav2. I asked my AI to dig into the root cause, and this seems to be the issue (I haven't fully validated it yet, but it looks reasonable to me)

Can you provide the exact error you are getting, and why do you think this is related to the patch in question? Feel free to use any AI tool, but please explain their reasoning to us. : )

[mini-1235]

@wep21 I am running into a similar issue to RoboStack/ros-lyrical#5 while testing Nav2. I asked my AI to dig into the root cause, and this seems to be the issue (I haven't fully validated it yet, but it looks reasonable to me)

Can you provide the exact error you are getting, and why do you think this is related to the patch in question? Feel free to use any AI tool, but please explain their reasoning to us. : )

@traversaro I will provide the detailed errors I saw over the weekend. Coincidentally, when I asked AI to verify whether this was actually the root cause yesterday, it came up with a repro example very similar to the one in RoboStack/ros-kilted#76 (comment).

The workaround I used yesterday was to preload the library as mentioned in RoboStack/ros-lyrical#5, and that resolved the issue for me.

[traversaro]

Ah ok, RoboStack/ros-kilted#76 (comment) make more sense as an issue.

[traversaro]

I think rather then removing the patch, we need to go back to https://github.com/RoboStack/ros-kilted/blob/main/patch/ros-kilted-rosidl-generator-py.osx.patch . To avoid confusion, I should probably update the upstream PR : ros2/rosidl_python#253 .

[mini-1235]

I think rather then removing the patch, we need to go back to https://github.com/RoboStack/ros-kilted/blob/main/patch/ros-kilted-rosidl-generator-py.osx.patch . To avoid confusion, I should probably update the upstream PR : ros2/rosidl_python#253 .

Okay! One question I have: if I split this change into a separate PR, will rosidl_python and the relevant dependent packages be rebuilt automatically, or would they only get rebuilt as part of a full rebuild?

ps: I suspect ros-lyrical has the same issue, since it uses the same patch as well

[traversaro]

I think rather then removing the patch, we need to go back to https://github.com/RoboStack/ros-kilted/blob/main/patch/ros-kilted-rosidl-generator-py.osx.patch . To avoid confusion, I should probably update the upstream PR : ros2/rosidl_python#253 .

Okay! One question I have: if I split this change into a separate PR, will rosidl_python and the relevant dependent packages be rebuilt automatically, or would they only get rebuilt as part of a full rebuild?

ps: I suspect ros-lyrical has the same issue, since it uses the same patch as well

If you do not change the build number, the package will not be rebuilt. The build number can be bumped as part of a full rebuild or also for a single package without a full rebuild.

[mini-1235]

Ah ok, I will just include it in #31 then. I originally split it out into a separate PR to try to get this part merged faster, since there are still a few issues to work through in that PR, but I will just include it there anyway