Uh oh!
There was an error while loading. Please reload this page.
chore: enable default pyrefly checking - #151
Merged
ruben-arts merged 1 commit intoSep 4, 2026
Merged
Conversation
baszalmstraforce-pushed
the
chore/enable-default-pyrefly-checking
branch
from
September 4, 2026 12:43
576f69a to
dbc5030Comparebaszalmstra
marked this pull request as ready for review
September 4, 2026 12:45
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pyrefly was falling back to its basic preset, so CI only caught parse errors, missing imports, and a small set of local issues. This moves package code to the default preset and makes the check part of the Pixi and CI workflows.
The default preset exposed incomplete type information around generated YAML documents and nullable command-line state. Those are now made explicit without changing the generated recipe format. While fixing the diagnostics, the migration version parser was also corrected to search the version segment rather than the accumulating integer list.
The type check deliberately excludes
test_*.py: those modules use partial fakes and mocks that are covered by pytest rather than treated as production interfaces.Testing
pixi run typecheck --output-format min-text --progress-bar nopixi run lint-check && pixi run fmt-checkpixi run python -m pytest vinca/test_archive_sources.py vinca/test_distro_dependencies.py vinca/test_naming_scheme.py vinca/test_provenance.py vinca/test_snapshot_metadata.py vinca/test_generate_gha.py vinca/test_pinning.py vinca/test_v1_selectors.py vinca/test_mutex.py vinca/test_sources.py vinca/test_recipes.py— 166 passed