chore: Bump fuselage packages - #41686
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughFuselage dependencies are upgraded across workspace packages. Contextual-bar components migrate from V2 wrappers to current Fuselage components. Button integrations use the ChangesFuselage API migration
Estimated code review effort: 2 (Simple) | ~15 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
juliajforesti
left a comment
There was a problem hiding this comment.
Since we are no longer renaming Contextualbar -> ContextualbarV2, there's no need to re-export these components here - you can update the imports where it it used to point to fuselage instead of ui-client.
also, for this PR to be merged, we need the latest version of fuselage, containing the proper replacement of v2 (RocketChat/fuselage#2137)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41686 +/- ##
===========================================
+ Coverage 68.61% 68.72% +0.10%
===========================================
Files 4162 4167 +5
Lines 158823 159437 +614
Branches 28168 28303 +135
===========================================
+ Hits 108979 109566 +587
- Misses 44673 44711 +38
+ Partials 5171 5160 -11
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Yep, I was wondering about that, will do this.
Yes, you're right. That's why this PR is still in draft. |
017a66f to
6abaa27
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui-video-conf/src/VideoConfMessage/VideoConfMessageButton.tsx`:
- Around line 4-7: Update VideoConfMessageButtonProps and the
VideoConfMessageButton component so the public size prop is not misleading:
either remove size from the props type, or use Button’s size type and forward
the caller-provided value while retaining small as the default.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: b83d879d-140e-45fb-aca7-6b3a8f4a0ef5
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (31)
apps/meteor/client/views/omnichannel/components/outboundMessage/components/TemplatePlaceholderSelector/TemplatePlaceholderButton.tsxapps/meteor/package.jsonapps/uikit-playground/package.jsonapps/uikit-playground/src/Components/Preview/Display/Surface/ContextualBarSurface.tsxpackages/fuselage-ui-kit/package.jsonpackages/gazzodown/package.jsonpackages/storybook-config/package.jsonpackages/ui-avatar/package.jsonpackages/ui-client/package.jsonpackages/ui-client/src/components/Contextualbar/Contextualbar.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarAction.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarActions.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarBack.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarButton.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarClose.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarContent.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarDialog.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarEmptyContent.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarFooter.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarHeader.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarIcon.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarSection.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarTitle.tsxpackages/ui-client/src/components/Contextualbar/index.tspackages/ui-client/src/components/EmojiPicker/EmojiPickerLoadMore.tsxpackages/ui-composer/package.jsonpackages/ui-contexts/package.jsonpackages/ui-video-conf/package.jsonpackages/ui-video-conf/src/VideoConfMessage/VideoConfMessageButton.tsxpackages/ui-voip/package.jsonpackages/web-ui-registration/package.json
💤 Files with no reviewable changes (9)
- packages/ui-client/src/components/Contextualbar/ContextualbarButton.tsx
- packages/ui-client/src/components/Contextualbar/ContextualbarAction.tsx
- packages/ui-client/src/components/Contextualbar/ContextualbarEmptyContent.tsx
- packages/ui-client/src/components/Contextualbar/ContextualbarSection.tsx
- packages/ui-client/src/components/Contextualbar/Contextualbar.tsx
- packages/ui-client/src/components/Contextualbar/ContextualbarIcon.tsx
- packages/ui-client/src/components/Contextualbar/ContextualbarContent.tsx
- packages/ui-client/src/components/Contextualbar/ContextualbarActions.tsx
- packages/ui-client/src/components/Contextualbar/ContextualbarFooter.tsx
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: Hacktron Security Check
⚠️ CI failures not shown inline (5)
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ✅ **Has milestone or project**
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**
GitHub Check: Dionisio QA: Some checks did not pass
Conclusion: failure
**Conclusion:** failure
### Steps
- ✅ **No merge conflicts**
- ❌ **QA assured** — This PR is missing the 'stat: QA assured' label
- ✅ **Mergeable**
- ❌ **Has milestone or project** — This PR is missing the required milestone or project
- ✅ **Valid PR title**
- ✅ **Correct target version**
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}
📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation
Files:
apps/meteor/client/views/omnichannel/components/outboundMessage/components/TemplatePlaceholderSelector/TemplatePlaceholderButton.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarHeader.tsxpackages/ui-video-conf/src/VideoConfMessage/VideoConfMessageButton.tsxpackages/ui-client/src/components/EmojiPicker/EmojiPickerLoadMore.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarClose.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarTitle.tsxapps/uikit-playground/src/Components/Preview/Display/Surface/ContextualBarSurface.tsxpackages/ui-client/src/components/Contextualbar/index.tspackages/ui-client/src/components/Contextualbar/ContextualbarDialog.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarBack.tsx
🧠 Learnings (7)
📚 Learning: 2026-06-16T14:13:34.463Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 40974
File: packages/web-ui-registration/package.json:31-31
Timestamp: 2026-06-16T14:13:34.463Z
Learning: In Rocket.Chat’s monorepo, when reviewing a dependency entry and flagging that a specific version “does not exist” (e.g., in package.json), first verify the exact package/version directly against the npm registry (use URLs like https://registry.npmjs.org/<package>/<version> or https://www.npmjs.com/package/<package>/v/<version>). Do not rely on web search results for this check, since they may be stale or cached and may not reflect the latest published versions.
Applied to files:
packages/ui-video-conf/package.jsonpackages/ui-voip/package.jsonpackages/ui-avatar/package.jsonpackages/storybook-config/package.jsonpackages/ui-contexts/package.jsonpackages/ui-client/package.jsonpackages/gazzodown/package.jsonpackages/fuselage-ui-kit/package.jsonpackages/ui-composer/package.jsonpackages/web-ui-registration/package.json
📚 Learning: 2026-06-16T14:13:49.795Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 40974
File: packages/web-ui-registration/package.json:26-26
Timestamp: 2026-06-16T14:13:49.795Z
Learning: During code reviews that check whether a dependency version exists in package.json (especially for Rocket.Chat’s rocket.chat/fuselage and related rocket.chat/fuselage-* packages), don’t rely on web search results. Instead, verify the version directly against the npm registry (e.g., via the npm registry API or the canonical package URL https://www.npmjs.com/package/<package>/v/<version>) before deciding that a version bump is invalid. If the version is present in the npm registry, do not flag it as invalid.
Applied to files:
packages/ui-video-conf/package.jsonpackages/ui-voip/package.jsonpackages/ui-avatar/package.jsonpackages/storybook-config/package.jsonpackages/ui-contexts/package.jsonpackages/ui-client/package.jsonpackages/gazzodown/package.jsonpackages/fuselage-ui-kit/package.jsonpackages/ui-composer/package.jsonpackages/web-ui-registration/package.json
📚 Learning: 2026-06-16T14:13:59.986Z
Learnt from: ricardogarim
Repo: RocketChat/Rocket.Chat PR: 40974
File: packages/ui-video-conf/package.json:25-25
Timestamp: 2026-06-16T14:13:59.986Z
Learning: In the Rocket.Chat monorepo, when reviewing a dependency version bump for rocket.chat/fuselage in a package.json, do not flag the new version constraint as “non-existent” or invalid unless you verify the published versions directly from the npm registry (https://www.npmjs.com/package/rocket.chat/fuselage). Don’t rely on search/web results for available versions since they can be stale.
Applied to files:
packages/ui-video-conf/package.jsonpackages/ui-voip/package.jsonpackages/ui-avatar/package.jsonpackages/storybook-config/package.jsonpackages/ui-contexts/package.jsonpackages/ui-client/package.jsonpackages/gazzodown/package.jsonpackages/fuselage-ui-kit/package.jsonpackages/ui-composer/package.jsonpackages/web-ui-registration/package.json
📚 Learning: 2026-03-27T14:52:56.865Z
Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.
Applied to files:
apps/meteor/client/views/omnichannel/components/outboundMessage/components/TemplatePlaceholderSelector/TemplatePlaceholderButton.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarHeader.tsxpackages/ui-video-conf/src/VideoConfMessage/VideoConfMessageButton.tsxpackages/ui-client/src/components/EmojiPicker/EmojiPickerLoadMore.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarClose.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarTitle.tsxapps/uikit-playground/src/Components/Preview/Display/Surface/ContextualBarSurface.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarDialog.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarBack.tsx
📚 Learning: 2026-05-06T12:21:44.083Z
Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.
Applied to files:
apps/meteor/client/views/omnichannel/components/outboundMessage/components/TemplatePlaceholderSelector/TemplatePlaceholderButton.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarHeader.tsxpackages/ui-video-conf/src/VideoConfMessage/VideoConfMessageButton.tsxpackages/ui-client/src/components/EmojiPicker/EmojiPickerLoadMore.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarClose.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarTitle.tsxapps/uikit-playground/src/Components/Preview/Display/Surface/ContextualBarSurface.tsxpackages/ui-client/src/components/Contextualbar/index.tspackages/ui-client/src/components/Contextualbar/ContextualbarDialog.tsxpackages/ui-client/src/components/Contextualbar/ContextualbarBack.tsx
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In the Rocket.Chat repository, do not reference Biome lint rules in code review feedback. Biome is not used even if biome.json exists; only reference Biome rules if there is explicit, project-wide usage documented. For TypeScript files, review lint implications without Biome guidance unless the project enables Biome rules.
Applied to files:
packages/ui-client/src/components/Contextualbar/index.ts
📚 Learning: 2026-02-26T19:25:44.063Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 38778
File: packages/ui-voip/src/providers/useMediaSession.ts:192-192
Timestamp: 2026-02-26T19:25:44.063Z
Learning: In this repository (RocketChat/Rocket.Chat), Biome lint rules are not used even if a biome.json exists. When reviewing TypeScript files (e.g., packages/ui-voip/src/providers/useMediaSession.ts), ensure lint suggestions do not reference Biome-specific rules. Rely on general ESLint/TypeScript lint rules and project conventions instead.
Applied to files:
packages/ui-client/src/components/Contextualbar/index.ts
🔇 Additional comments (21)
apps/meteor/package.json (1)
112-113: LGTM!apps/uikit-playground/package.json (1)
21-21: LGTM!packages/fuselage-ui-kit/package.json (1)
49-49: LGTM!packages/gazzodown/package.json (1)
33-33: LGTM!packages/storybook-config/package.json (1)
36-36: LGTM!packages/ui-avatar/package.json (1)
20-20: LGTM!packages/ui-client/package.json (1)
29-29: LGTM!packages/ui-composer/package.json (1)
25-25: LGTM!packages/ui-contexts/package.json (1)
26-26: LGTM!packages/ui-video-conf/package.json (1)
26-26: LGTM!packages/ui-voip/package.json (1)
34-34: LGTM!packages/web-ui-registration/package.json (1)
26-26: LGTM!apps/uikit-playground/src/Components/Preview/Display/Surface/ContextualBarSurface.tsx (1)
6-23: LGTM!Also applies to: 53-59
packages/ui-client/src/components/Contextualbar/ContextualbarBack.tsx (1)
1-5: LGTM!packages/ui-client/src/components/Contextualbar/ContextualbarClose.tsx (1)
1-5: LGTM!packages/ui-client/src/components/Contextualbar/ContextualbarDialog.tsx (1)
4-10: LGTM!packages/ui-client/src/components/Contextualbar/ContextualbarHeader.tsx (1)
1-6: LGTM!packages/ui-client/src/components/Contextualbar/ContextualbarTitle.tsx (1)
1-5: LGTM!packages/ui-client/src/components/Contextualbar/index.ts (1)
8-21: LGTM!apps/meteor/client/views/omnichannel/components/outboundMessage/components/TemplatePlaceholderSelector/TemplatePlaceholderButton.tsx (1)
11-11: LGTM!packages/ui-client/src/components/EmojiPicker/EmojiPickerLoadMore.tsx (1)
6-6: LGTM!
There was a problem hiding this comment.
All reported issues were addressed across 32 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Proposed changes (including videos or screenshots)
Release changes -
@rocket.chat/fuselage@0.85.0
@rocket.chat/fuselage-forms@1.5.1
Chores -
ContextualBarV1and movedContextualBarV2as the onlyContextualBarcomponent api on fuselage. This PR includes the required cleanup on core, removes all references onContextualBarV2and replace it with the only availableContextualBarcomponents.sizeprops on button componentIssue(s)
Steps to test or reproduce
Further comments
CORE-2511
Summary by CodeRabbit
UI Improvements
Maintenance