chore: upgrade stale dependencies - #2114
Merged
Merged
Conversation
Bumps eslint 9.39.5 -> 10.7.0, typescript-eslint -> 8.64.0, eslint-plugin-react-hooks -> 7.1.1, and globals -> 17.7.0 across the workspace. Wraps eslint-plugin-react with @eslint/compat's fixupPluginRules since it still relies on APIs ESLint 10 removed, and pins @types/eslint-scope to 9.1.0 to resolve a type conflict with ESLint 10's updated Scope types (a stale transitive type package pulled in by webpack). eslint-plugin-storybook stays on 9.x since its latest requires a Storybook v10 upgrade, which is out of scope here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Bumps webpack 5.105.4 -> 5.108.4, webpack-cli 6.0.1 -> 7.2.1, sass-loader 16.0.8 -> 17.0.0, and ts-loader 9.5.7 -> 9.6.2 in fuselage. Also drops the redundant direct webpack dependency from fuselage-forms, which builds with tsc and only uses webpack transitively via @storybook/react-webpack5 (matching its sibling Storybook-only packages). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bumps sass 1.100.0 -> 1.101.0, postcss 8.5.19 -> 8.5.20, and the PostCSS plugins postcss-logical 8.1.0 -> 9.0.0, postcss-dir-pseudo-class 9.0.1 -> 10.0.0, and cssnano 7.1.9 -> 8.0.2. The csstools plugin majors drop their CommonJS API but are imported via ESM in webpack.config.js. The generated fuselage bundle (CSS + JS) is byte-for-byte identical, and the 505 visual regression tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bumps stylelint 17.12.0 -> 17.14.0 (across fuselage, fuselage-tokens, icons, and the build tooling) and stylelint-scss 7.1.1 -> 7.2.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The generated @rocket.chat/logo output (logo.png, logo.svg, and the full dist tree) is byte-for-byte identical despite the bundled libvips bump (8.17.3 -> 8.18.3). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The generated @rocket.chat/fuselage-tokens dist output is byte-for-byte identical. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bumps rollup across emitter, css-in-js, fuselage-hooks, and mp3-encoder (the @rollup plugins were already at their latest versions). The generated dist output of all four packages is byte-for-byte identical. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: a14ea2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ggazzo
previously approved these changes
Jul 22, 2026
tassoevan
dismissed
ggazzo’s stale review
July 22, 2026 13:53
actually at least one package need a patch changeset
Only @rocket.chat/css-in-js had a runtime dependency upgraded (stylis 4.3.6 -> 4.4.0). All other upgrades were dev/peer dependencies or in private tooling packages, which do not warrant a release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tassoevan
marked this pull request as draft
July 22, 2026 13:54
…ible
The script is launched via `sh`, which on Ubuntu CI is dash (not bash),
so the bash-only `${BASH_SOURCE[0]}` expanded to empty and the Playwright
version lookup resolved to a non-existent packages/package.json, failing
the visual-regression job. Resolve the tool's package.json from the
already-computed MONOREPO_ROOT instead, and replace the bash `[[ ]]` test
with a POSIX `case` so --update-snapshots detection also works under dash.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tassoevan
marked this pull request as ready for review
July 22, 2026 14:33
ggazzo
approved these changes
Jul 22, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Maintenance pass upgrading stale build/tooling dependencies across the monorepo. Each change was verified so that lint passes and generated outputs stay unchanged where a package produces build artifacts.
eslint9→10,typescript-eslint,eslint-plugin-react-hooks5→7,globals16→17). Wrappedeslint-plugin-reactwith@eslint/compat'sfixupPluginRules(it still relies on APIs removed in ESLint 10) and pinned@types/eslint-scopeto resolve a type conflict.eslint-plugin-storybookstays on 9.x (its latest requires a Storybook v10 upgrade, out of scope).webpack5.108,webpack-cli6→7,sass-loader16→17,ts-loader). Dropped the redundant directwebpackdependency fromfuselage-forms(it builds withtsc; webpack is transitive via@storybook/react-webpack5). Fixed a Storybooksass-loaderregression (v17 changed how theimplementationoption loads).sass1.101,postcss8.5.20,postcss-logical8→9,postcss-dir-pseudo-class9→10,cssnano7→8). The generated@rocket.chat/fuselagebundle (CSS + JS) is byte-for-byte identical and all 505 visual-regression tests pass.stylelint17.14,stylelint-scss7.2).@rocket.chat/logooutput (incl. the rasterizedlogo.png) is byte-for-byte identical despite the bundled libvips bump.@rocket.chat/fuselage-tokensoutput is byte-for-byte identical.distoutput of all four rollup-built packages (emitter,css-in-js,fuselage-hooks,mp3-encoder) is byte-for-byte identical.Some packages could not reach their absolute-latest version because this repo enforces a 3-day minimum-package-age gate (
npmMinimalAgeGate); those were taken to the newest version that clears the gate.Issue(s)
Further comments
yarn lint --forcepasses,yarn build-storybooksucceeds, and the@rocket.chat/fuselagevisual-regression suite passes (505/505). For every package that emits build artifacts, the generated output was diffed against a pre-upgrade baseline and confirmed unchanged.