chore: Deprecate legacy AutoComplete, Contextualbar, Sidebar and TopBar components - #2135
Merged
Merged
Conversation
Mark the `AutoComplete` component and its props type as deprecated in favor of `SelectFiltered` and `MultiSelectFiltered`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Mark the wrapped `AutoComplete` component as deprecated in favor of `MultiSelectFiltered`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Mark all `Contextualbar*` components and their props types as deprecated in favor of their `ContextualbarV2*` counterparts. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Mark the legacy `Sidebar*` components and their props types as deprecated in favor of their `SidebarV2*` counterparts. The `TopBar*` components exported from the same directory are left untouched, as they are not superseded by `SidebarV2`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Mark every `TopBar*` export, including `TopBarV2` and the `SidebarTopBar*` aliases, as deprecated in favor of `NavBar` for app-level navigation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 406169c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
juliajforesti
approved these changes
Jul 30, 2026
|
Tick the box to add this pull request to the merge queue (same as
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Marks the legacy component families as deprecated through
@deprecatedJSDoc, so consumers get IDE and API-report warnings before they are removed. No runtime behavior changes — comments only.AutoComplete(@rocket.chat/fuselage)SelectFiltered/MultiSelectFilteredAutoComplete(@rocket.chat/fuselage-forms)MultiSelectFilteredContextualbar*ContextualbarV2*Sidebar*SidebarV2*TopBar*,TopBarV2,SidebarTopBar*NavBarNotes on the mapping:
Contextualbarfamily is a 1:1 rename, so every component and props type points at itsContextualbarV2*counterpart.Sidebarfamily is not 1:1. Where a counterpart exists it is named (for exampleSidebarItemTime→SidebarV2ItemTimestamp,SidebarItemAvatar→SidebarV2ItemAvatarWrapper,SidebarSectionTitle→SidebarV2GroupTitle).SidebarItemContainer,SidebarItemWrapperandSidebarItemSubtitlehave no V2 equivalent, since V2 restructured them intoSidebarV2ItemRow/SidebarV2ItemCol, so those point at the family instead of asserting a replacement.TopBarandTopBarV2are deprecated, so there is no in-family successor; they point atNavBarfor app-level navigation.export default memo(X)in theContextualbarfamily, where JSDoc on the inner declaration does not attach to the exported symbol. The tags are therefore placed on theexport defaultstatements, which is what makes them show up in the API reports.Issue(s)
Further comments
Verified per commit:
yarn buildfor both affected packages (api-extractor regeneratedfuselage.api.mdandfuselage-forms.api.md, and the reports confirm every intended export flipped to@public @deprecatedand nothing else did), plusyarn lint(0 errors, only the 3 pre-existingreact-hooks/exhaustive-depswarnings inMultiSelect/SelectLegacy) andtsc --noEmit.Unit tests and visual regression were not run — the changes are comments only and do not affect rendered output.