Skip to content

feat(dynamic-table): introduce dynamic-table module - #12

Open
ditoglez wants to merge 2 commits into
masterfrom
enhancement/6
Open

feat(dynamic-table): introduce dynamic-table module#12
ditoglez wants to merge 2 commits into
masterfrom
enhancement/6

Conversation

@ditoglez

Copy link
Copy Markdown
Contributor

WIP: Adds dynamic-table module
@flore2003, @erzaehlsalex let's see what else we can do here.

Closes#6

@ditoglezditoglez added the enhancement New feature or request label Sep 6, 2018
@ditoglez
ditoglezforce-pushed the enhancement/6 branch 2 times, most recently from 8bfd873 to 09c3d67CompareSeptember 7, 2018 08:41
@ditoglezditoglez changed the title enhancement/6 - add dynamic-table modulefeat(dynamic-table): introduce dynamic-table moduleSep 7, 2018
@ditoglez
ditoglezforce-pushed the enhancement/6 branch 21 times, most recently from 7db4c80 to ea73422CompareSeptember 10, 2018 11:50
@ditoglez
ditoglezforce-pushed the enhancement/6 branch 2 times, most recently from 5869f08 to cc792b5CompareSeptember 12, 2018 08:09
@ditoglez

Copy link
Copy Markdown
ContributorAuthor

@flore2003, I think we have to review this codeclimate stuff 🤣

@mbeckenbach

Copy link
Copy Markdown

@flore2003@erzaehlsalex
Had a look at the codeclimate results. This does not seam to be important. It's only complaining that we have similar code blocks in the unit test test data. Is it really necessary to fix these?

image

@mbeckenbach

Copy link
Copy Markdown

Found some Errors that webstom marks as build errors:

image

Could be resolved by adding Observable to the imports like described here:
https://stackoverflow.com/questions/54145091/public-property-x-of-exported-class-has-or-is-using-name-observable-from-exter

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Component/Service] Dynamic Table Component

4 participants

@ditoglez@mbeckenbach@flore2003@erzaehlsalex