Skip to content

feat(number-input): introduce number-input module - #4

Open
ditoglez wants to merge 1 commit into
masterfrom
enhancement/2
Open

feat(number-input): introduce number-input module#4
ditoglez wants to merge 1 commit into
masterfrom
enhancement/2

Conversation

@ditoglez

@ditoglezditoglez commented Sep 3, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds number-input module to the library, unit tests.

Closes#2

@ditoglezditoglez added the enhancement New feature or request label Sep 3, 2018
@ditoglezditoglez changed the title enhancement/number-input-component - add number-input component to the libenhancement/2- add number-input component to the libSep 3, 2018
@flore2003

flore2003 commented Sep 5, 2018

Copy link
Copy Markdown
Member

See discussion in #2
We also need to rebase this onto master 🙂

ditoglez pushed a commit that referenced this pull request Sep 6, 2018
Fernando Gonzalez Goncharov
enhancement/4 - add dynamic table module
c4ff88f
Closes#4
@flore2003

flore2003 commented Sep 7, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Is there a good reason we are copying the testing utilities from angular/material2? Can we not just use the @angular/cdk package to include the testing utilities in our library?

@flore2003

flore2003 commented Sep 7, 2018

Copy link
Copy Markdown
Member

@ditoglez This also still has the rp prefix, we should update this to reflect the new ngr prefix. I also changed the default style to 4 spaces instead of 2, we should update all open pull requests to reflect this.

ditoglez pushed a commit that referenced this pull request Sep 7, 2018
Fernando Gonzalez Goncharov
enhancement/4 - add dynamic table module
cee84b8
Closes#4
@ditoglez
ditoglezforce-pushed the enhancement/2 branch 3 times, most recently from 45da85e to fa02d35CompareSeptember 7, 2018 09:12
@ditoglezditoglez changed the title enhancement/2- add number-input component to the libfeat(number-input): introduce number-input moduleSep 7, 2018
flore2003
flore2003 requested changes Sep 7, 2018
View reviewed changes

@flore2003flore2003 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this PR and solve the conflicts it has with master?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flore2003flore2003flore2003 requested changes
@erzaehlsalexerzaehlsalexAwaiting requested review from erzaehlsalex

Assignees

@flore2003flore2003

@erzaehlsalexerzaehlsalex

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ditoglez@flore2003@erzaehlsalex