Remove printer mixins; printer-side TakeItOutCompat handles the integration - #5
Open
BiliXWhite wants to merge 2 commits into
Open
Remove printer mixins; printer-side TakeItOutCompat handles the integration#5BiliXWhite wants to merge 2 commits into
BiliXWhite wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The refactored litematica-printer (26.2+) now actively adapts to TakeItOut
through its own
TakeItOutCompatininterfaces/compat/:ModuleManager.tick()callsTakeItOutCompat.isAwaitingItem()toblock all module processing while a server-side extraction is pending
→ replaces the old
NewPrinterMixinHEAD injection onClientPlayerTickManager.tick()/ModuleManager.tick()InventoryUtils.switchToItems()callsTakeItOutCompat.tryExtract()as a last resort when the required item is not in the player's
inventory and QuickShulker is unavailable
→ replaces the TAIL injection that manually scanned
PrinterBoxpositions for shulker extractions
Since the printer side now fully drives the TakeItOut integration,
the TakeItOut-side
NewPrinterMixinis entirely redundant and hasbeen removed.
Also, I fixed gradle's dependency request, which should not be hardcoded with "libs/".