ci: add OPC Classic integration testing - #25
Conversation
Warning Review limit reached
Next review available in:54 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThe PR adds pinned Windows Rust validation, an ignored OPC DA integration test, OPC Kit Server setup and cleanup automation, and a tag-triggered workflow that publishes selected crates. ChangesOPC integration CI
Release automation
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant OPC Kit Server
participant Windows Registry
participant opc_kit integration test
GitHub Actions->>OPC Kit Server: download and verify executable
GitHub Actions->>Windows Registry: register and validate ProgID
GitHub Actions->>opc_kit integration test: run ignored OPC DA test
opc_kit integration test->>OPC Kit Server: connect, read, write, and read back
GitHub Actions->>OPC Kit Server: terminate and unregister server
GitHub Actions->>Windows Registry: verify registration removal
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/rust.yml:
- Around line 116-123: Update the post-registration validation around the 32-bit
and 64-bit registry queries so setup fails unless both $reg32Exit and $reg64Exit
indicate successful registration. Keep the existing registry diagnostics log and
failure message, but change the condition from accepting either view to
requiring both views before tests run.
In `@opc_da_bindings/tests/opc_kit.rs`:
- Around line 127-163: Update the write round-trip test around its write
operation to preserve before.value and restore it through cleanup that runs
after every write attempt, including failed writes or assertions. Reuse the
existing group.write API and write_item.server_handle, ensuring the original
value is restored before returning while preserving the current validation
behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 67695c21-097a-4d3a-bec7-27e633fbff6c
📒 Files selected for processing (4)
.github/workflows/rust-clippy.yml.github/workflows/rust.ymlREADME.mdopc_da_bindings/tests/opc_kit.rs
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Line 29: Update every uses entry in the release workflow, including
actions/checkout and dtolnay/rust-toolchain, to reference a trusted immutable
40-character commit SHA instead of a tag, branch, or other mutable reference;
preserve each action’s current version and workflow behavior.
- Around line 56-61: Update the release workflow’s package-publishing loop to
invoke `cargo publish --locked --package` separately for each package in
dependency order, rather than accumulating all packages in `$arguments`. Before
each upload, query crates.io and skip only when that exact package version
already exists; otherwise publish it individually while preserving retry
behavior for partial failures.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: aa5f0342-0e94-467d-8cf9-16b7e9763093
📒 Files selected for processing (1)
.github/workflows/release.yml
| runs-on: windows-latest | ||
| steps: | ||
| - name: Check out release | ||
| uses: actions/checkout@v7 |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"## workflow excerpt"
sed -n '1,90p' .github/workflows/release.yml 2>/dev/null ||trueechoecho"## uses references"
rg -n 'uses:\s*[^#]+' .github/workflows/release.yml 2>/dev/null ||trueechoecho"## id-token permission"
rg -n 'id-token|permissions:' .github/workflows/release.yml 2>/dev/null ||trueRepository: Ronbb/rust_opc
Length of output: 2068
Security Misconfiguration (CWE-829): Inclusion of Functionality from Untrusted Control Sphere
Reachability: External
Pin every action to a full commit SHA.
Lines 29, 32, 37, and 41 use mutable references, including dtolnay/rust-toolchain@master. If a referenced action is retargeted or compromised before the tag trigger runs, its code executes with id-token: write and can mint the workflow’s OIDC token for crates.io Trusted Publishing. Replace each uses: value with a 40-character commit SHA.
🧰 Tools
🪛 zizmor (1.29.0)
[warning] 28-29: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/release.yml at line 29, Update every uses entry in the
release workflow, including actions/checkout and dtolnay/rust-toolchain, to
reference a trusted immutable 40-character commit SHA instead of a tag, branch,
or other mutable reference; preserve each action’s current version and workflow
behavior.
| $arguments = @("publish", "--locked") | ||
| foreach ($package in $packages) { | ||
| $arguments += @("--package", $package) | ||
| } | ||
| & cargo @arguments |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"== workflow excerpt =="if [ -f .github/workflows/release.yml ];then
nl -ba .github/workflows/release.yml | sed -n '1,140p'elseecho"missing .github/workflows/release.yml"fiecho"== packages/manifest names =="
python3 - <<'PY'import os, refor root, dirs, files in os.walk('.'): dirs[:] = [d for d in dirs if d not in {'.git','target','node_modules'}] if 'Cargo.toml' in files: path=os.path.join(root,'Cargo.toml') with open(path, encoding='utf-8') as f: data=f.read() m=re.search(r'^\[package\].*?^name\s*=\s*"(.*?)"', data, re.M|re.S) if m: print(path, m.group(1))PYecho"== references to opc_classic/opc_comn in repo =="
rg -n "opc_classic|opc_comn|publish|cargo publish|crates.io" .github Cargo.toml Cargo.lock 2>/dev/null ||trueRepository: Ronbb/rust_opc
Length of output: 215
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"== workflow excerpt =="if [ -f .github/workflows/release.yml ];then
awk '{printf "%6d\t%s\n", NR, $0}' .github/workflows/release.yml | sed -n '1,140p'elseecho"missing .github/workflows/release.yml"fiecho"== package manifests and dependency-like fields =="
python3 - <<'PY'import os, refor root, dirs, files in sorted(os.walk('.')): dirs[:] = sorted([d for d in dirs if d not in {'.git','target','node_modules'}]) if 'Cargo.toml' in files: path=os.path.join(root,'Cargo.toml') with open(path, encoding='utf-8') as f: data=f.read() name=None lines=[] for line in data.splitlines(): if re.match(r'^name\s*=\s*"([^"]+)"', line): name=re.match(r'^name\s*=\s*"([^"]+)"', line).group(1) stripped=line.strip() if any(key in stripped for key in ['dependencies','dev-dependencies','build-dependencies','[workspace]', 'members', 'workspace.package.version', 'build']): lines.append(line) if name: print("---", path, name, "---") for line in lines: print(line)PYecho"== references to opc_classic/opc_comn in relevant files =="
rg -n "opc_classic|opc_comn|publish|cargo publish|crates.io" .github Cargo.toml Cargo.lock 2>/dev/null ||trueRepository: Ronbb/rust_opc
Length of output: 7119
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"== package toml files =="forfin opc_classic_types/Cargo.toml opc_classic_utils/Cargo.toml opc_comn_bindings/Cargo.toml opc_classic_abi/Cargo.toml;doif [ -f"$f" ];thenecho"--- $f ---"
awk '{printf "%6d\t%s\n", NR, $0}'"$f"fidoneecho"== workspace package versions =="
awk '/^\[workspace\.package\]/{flag=1} flag; /^\[workspace\]/{if (NR>1) flag=0}' Cargo.toml | awk '{printf "%6d\t%s\n", NR, $0}'echo"== lockfile relevant packages =="
python3 - <<'PY'from pathlib import Pathimport retext = Path("Cargo.lock").read_text()for pkg in ("opc_classic_types", "opc_classic_utils", "opc_comn_bindings"): m = re.search(r'\n\s*\[\[package\]\]\n(.*?)\nname = "' + re.escape(pkg) + '"\n', text, re.S) print(f"--- {pkg} ---") print(m.group(0)[:500] if m else "not found")PYecho"== Cargo.lock dependency edges for publish packages =="
python3 - <<'PY'from pathlib import Pathimport relock = Path("Cargo.lock").read_text()for name in ("opc_classic_types", "opc_classic_utils", "opc_comn_bindings"): sections = re.split(r'(?=\[\[package\]\])', lock) pkg = next((s for s in sections if f'name = "{name}"' in s), None) print(f"--- deps for {name} ---") for line in (pkg or "").splitlines(): if "dependencies" in line or ("name =" in line and pkg): pass # concise dependency block m=re.search(r'name = "' + re.escape(name) + '".*?(?=^name = |\Z)', pkg, re.S|re.M) if m: block=m.group(0) for line in block.splitlines(): if line.startswith('dependencies =') or line.startswith('"') or '=' in line: print(line)PYecho"== deterministic publish command shape =="
python3 - <<'PY'import reworkflow = open(".github/workflows/release.yml").read()fn = re.search(r'foreach \(\$package in \$packages\) \{[^}]+\}', workflow, re.S)print(fn.group(0))items = re.findall(r'"([^"]+)"', fn.group(0))print("items:", items)print("final command:", " ".join(["cargo", "publish", "--locked"] + [arg for item in items for arg in ["--package", item]]))PYRepository: Ronbb/rust_opc
Length of output: 5702
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"== lockfile package section exact =="
python3 - <<'PY'from pathlib import Pathimport relock = Path("Cargo.lock").read_text()for name in ("opc_classic_types", "opc_classic_utils", "opc_comn_bindings"): print(f"--- {name} lock section ---") p = re.search(r'(?ms)(^\[\[package\]\].*?(?=^\[\[package\]\]|\Z))', lock) for m in re.finditer(r'(?ms)^\[\[package\]\]\n((?:.*?\n)*?)^name = "'+ re.escape(name) +'"', lock): # no, wrong: find containing name line under package passPY# simpler exact:
python3 - <<'PY'from pathlib import Pathimport relock = Path("Cargo.lock").read_text()sections = re.split(r'(?=^\[\[package\]\])', lock, flags=re.M)for name in ("opc_classic_types", "opc_classic_utils", "opc_comn_bindings"): section = next((s for s in sections if re.search(r'^name = "'+re.escape(name)+'"$', s, re.M)), None) print(f"--- {name} sections={section is not None} ---") print(section if section else "NO SECTION")PYecho"== workflow parse exact item order =="
python3 - <<'PY'from pathlib import Pathimport retext = Path(".github/workflows/release.yml").read_text()# find package list block inside publish stepstart = text.find('[$packages = @(')end = text.find(')', start)# fallback broadm = re.search(r'\$packages\s*=\s*@.*?\)', text, re.S)print("m:", bool(m))print("package block:")print(m.group(0))print("quoted package values:")print(sorted(re.findall(r'"([^"]+)"', m.group(0)), key=lambda s: None)) # bad?print(sorted(re.findall(r'"([^"]+)"', m.group(0))))# print whole publish section line numbersfor i,line in enumerate(text.splitlines(), 1): if 'Publish crates' in line or 'cargo `@arguments`' in line: print("line", i, line)PYRepository: Ronbb/rust_opc
Length of output: 144
🏁 Script executed:
#!/bin/bashset -euo pipefail
echo"== lockfile package summary for publish packages =="fornamein opc_classic_types opc_classic_utils opc_comn_bindings;doecho"--- $name version and deps ---"
grep -nE '^(name|version|dependencies|source|dependencies|optional) =|name = "'"$name"'"$|dependencies = \[' Cargo.lock | head -80
done| sed -n '1,120p'echo"== package list in workflow =="
python3 - <<'PY'from pathlib import Pathimport retext = Path(".github/workflows/release.yml").read_text()m = re.search(r'\$packages\s*=\s*@.*?\)', text, re.S)print(m.group(0))print([s for s in m.group(0).split(',') if '"' in s])PYecho"== deterministic publish command shape =="
python3 - <<'PY'packages = ["opc_classic_types", "opc_classic_utils", "opc_comn_bindings"]command = ["cargo", "publish", "--locked"] + [x for p in packages for x in ["--package", p]]print(" ".join(command))PYRepository: Ronbb/rust_opc
Length of output: 4304
Publish crates one at a time before the retryable upload.
This step sends cargo publish --locked --package opc_classic_types --package opc_classic_utils --package opc_comn_bindings as one command, so it can publish the earlier crates before a later crate fails. Crate releases cannot be overwritten, and index availability can lag after upload. Run cargo publish --locked --package for each package in dependency order. Before each upload, skip the exact package and version only if it already exists on crates.io. Test the partial-failure retry flow against crates.io staging.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/release.yml around lines 56 - 61, Update the release
workflow’s package-publishing loop to invoke `cargo publish --locked --package`
separately for each package in dependency order, rather than accumulating all
packages in `$arguments`. Before each upload, query crates.io and skip only when
that exact package version already exists; otherwise publish it individually
while preserving retry behavior for partial failures.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Verification
cargo test --workspace --all-targetscargo clippy --workspace --all-targets --all-features -- -D warningscargo fmt --all -- --checkwindows-latest:Simulation.Register_I4 = I32(12345), quality0x00c0, non-zero timestampGitHub Actions run: https://github.com/Ronbb/rust_opc/actions/runs/31068173343
Summary by CodeRabbit
Tests
Documentation
Release