Skip to content

fix(servers): show a friendly error when cache-alert resolve fails - #784

Merged
RonenMars merged 1 commit into
mainfrom
fix/cache-alert-resolve-error
Aug 20, 2026
Merged

fix(servers): show a friendly error when cache-alert resolve fails#784
RonenMars merged 1 commit into
mainfrom
fix/cache-alert-resolve-error

Conversation

@RonenMars

@RonenMars RonenMars commented Aug 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Catch failed cache-alert resolve (prune / ignore / reset) instead of leaving an uncaught NetworkError.
  • Keep the sheet open and show a plain retry message so the user can try again.

Test plan

  • Open a cache-alert sheet and confirm a successful prune still resolves as before.
  • Force a failed resolve (unreachable server or 502) and confirm the red LogBox does not appear.
  • Confirm the sheet stays open with: "Couldn't complete that action. Check the connection to this server and try again."
  • Tap Proceed again after a failure and confirm the error clears while the request is in flight.

@RonenMars
RonenMars changed the base branch from integration/2026-08-18-open-prs to main August 20, 2026 06:49
@RonenMars
RonenMars force-pushed the fix/cache-alert-resolve-error branch from 95be748 to e68f15c Compare August 20, 2026 07:36
@RonenMars
RonenMars merged commit 156da00 into main Aug 20, 2026
10 checks passed
@RonenMars
RonenMars deleted the fix/cache-alert-resolve-error branch August 20, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant