Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

Handle stdin-stream control-flow errors gracefully - #11811

Merged
cte merged 1 commit into
mainfrom
codex/stdin-stream-control-flow-errors
Mar 1, 2026
Merged

Handle stdin-stream control-flow errors gracefully#11811
cte merged 1 commit into
mainfrom
codex/stdin-stream-control-flow-errors

Conversation

@cte

@ctecte commented Mar 1, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add a shared expected-control-flow error classifier for stdin stream mode
  • treat abort/cancel variants, no-active-task cancel races, and stream teardown-on-shutdown as non-fatal control flow
  • apply classifier in both CLI runtime unhandled error handlers and stdin-stream client/cancel paths
  • add focused unit tests for new classifiers and contexts

Interactively review PR in Roo Code Cloud

@dosubotdosubotBot added size:L This PR changes 100-499 lines, ignoring generated files. Enhancement New feature or request labels Mar 1, 2026
@dosubotdosubotBot added the lgtm This PR has been approved by a maintainer label Mar 1, 2026
@cte
cte merged commit 52d606b into mainMar 1, 2026
17 checks passed
@cte
cte deleted the codex/stdin-stream-control-flow-errors branch March 1, 2026 20:01
@github-project-automationgithub-project-automationBot moved this from New to Done in Roo Code RoadmapMar 1, 2026
@ctecte mentioned this pull request Mar 1, 2026
Merged
3 tasks
@github-actionsgithub-actionsBot mentioned this pull request Mar 4, 2026
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrubensmrubensAwaiting requested review from mrubensmrubens is a code owner
@jrjrAwaiting requested review from jr
@daniel-lxsdaniel-lxsAwaiting requested review from daniel-lxsdaniel-lxs is a code owner
1 more reviewer
@hannesrudolphhannesrudolphhannesrudolph approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

EnhancementNew feature or requestlgtmThis PR has been approved by a maintainersize:LThis PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cte@hannesrudolph