Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on May 15, 2026. It is now read-only.
fix(cli): ignore model-provided timeout in CLI runtime - #11835
Merged
Conversation
In CLI runtime, stdin harnesses expect command lifetime to be governed solely by commandExecutionTimeout (user setting), not model-provided background timeouts. Extract resolveAgentTimeoutMs() and return 0 when ROO_CLI_RUNTIME=1. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cte
requested review from
daniel-lxs, hannesrudolph, jr and mrubens
as code ownersMarch 2, 2026 21:24
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveAgentTimeoutMs()from inline timeout logic inExecuteCommandTool0(no agent timeout) whenROO_CLI_RUNTIME=1, so command lifetime is governed solely by the user'scommandExecutionTimeoutsettingTest plan
resolveAgentTimeoutMs(CLI runtime returns 0, non-CLI returns converted ms)🤖 Generated with Claude Code
Interactively review PR in Roo Code Cloud