Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

cli: ensure full command output is streamed before done - #11842

Merged
cte merged 1 commit into
mainfrom
split/cli-command-output-stream-fix
Mar 3, 2026
Merged

cli: ensure full command output is streamed before done#11842
cte merged 1 commit into
mainfrom
split/cli-command-output-stream-fix

Conversation

@cte

@ctecte commented Mar 3, 2026•
edited by ghost
Loading

Copy link
Copy Markdown
Contributor

Summary

  • fix race where fast commands could emit done before all output was streamed
  • defer exited completion until final command_output payload (with fallback timeout)
  • add regression test for truncated fast-exit output streaming

Notes

  • scoped to CLI streaming/event emitter files only

Interactively review PR in Roo Code Cloud

@dosubotdosubotBot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Mar 3, 2026
@cte
cte merged commit d048036 into mainMar 3, 2026
15 checks passed
@cte
cte deleted the split/cli-command-output-stream-fix branch March 3, 2026 05:50
@github-project-automationgithub-project-automationBot moved this from New to Done in Roo Code RoadmapMar 3, 2026
@github-actionsgithub-actionsBot mentioned this pull request Mar 4, 2026
Merged
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrubensmrubensAwaiting requested review from mrubensmrubens is a code owner
@jrjrAwaiting requested review from jr
@hannesrudolphhannesrudolphAwaiting requested review from hannesrudolph
@daniel-lxsdaniel-lxsAwaiting requested review from daniel-lxsdaniel-lxs is a code owner

Assignees

No one assigned

Labels

bugSomething isn't workingsize:LThis PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@cte