Revert "fix: use safeWriteJson for all JSON file writes" by mrubens · Pull Request #4471 · RooCodeInc/Roo-Code

mrubens · 2025-06-09T17:47:05Z

Reverts #3772

Looks like this causes issues with saving history, and possibly other things.

Important

Reverts atomic JSON file writes using safeWriteJson, replacing with fs.writeFile, and updates related tests and documentation.

Behavior:
- Reverts use of safeWriteJson for JSON file writes, replacing it with fs.writeFile in modelCache.ts, modelEndpointCache.ts, importExport.ts, FileContextTracker.ts, apiMessages.ts, taskMessages.ts, webviewMessageHandler.ts, and McpHub.ts.
- Removes atomic write guarantees and locking mechanisms previously provided by safeWriteJson.
Tests:
- Removes safeWriteJson tests from safeWriteJson.test.ts.
- Updates tests in cache-manager.test.ts and McpHub.test.ts to reflect changes from safeWriteJson to fs.writeFile.
Documentation:
- Deletes use-safeWriteJson.md rule documentation.
Dependencies:
- Removes proper-lockfile and stream-json from package.json dependencies.

^{This description was created by}^{for d47929e. You can customize this summary. It will automatically update as commits are pushed.}

This reverts commit 1be30fc.

KJ7LNW · 2025-06-15T21:21:31Z

See also: #4468

Fix race condition where safeWriteJson would fail with ENOENT errors during lock acquisition when the parent directory was just created. The issue occurred when the directory creation hadn't fully synchronized with the filesystem before attempting to acquire a lock. This happened primarily when Task.saveApiConversationHistory() called the function immediately after creating the task directory. The fix ensures directories exist and are fully synchronized before lock acquisition by: - Creating directories with fs.mkdir({ recursive: true }) - Verifying access to created directories - Setting realpath: false in lock options to allow locking non-existent files Added comprehensive tests for directory creation capabilities. Fixes: #4468 See-also: #4471, #3772, #722 Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>

mrubens · 2025-06-09T17:47:05Z

Reverts #3772

Looks like this causes issues with saving history, and possibly other things.

Important

Reverts atomic JSON file writes using safeWriteJson, replacing with fs.writeFile, and updates related tests and documentation.

Behavior:
- Reverts use of safeWriteJson for JSON file writes, replacing it with fs.writeFile in modelCache.ts, modelEndpointCache.ts, importExport.ts, FileContextTracker.ts, apiMessages.ts, taskMessages.ts, webviewMessageHandler.ts, and McpHub.ts.
- Removes atomic write guarantees and locking mechanisms previously provided by safeWriteJson.
Tests:
- Removes safeWriteJson tests from safeWriteJson.test.ts.
- Updates tests in cache-manager.test.ts and McpHub.test.ts to reflect changes from safeWriteJson to fs.writeFile.
Documentation:
- Deletes use-safeWriteJson.md rule documentation.
Dependencies:
- Removes proper-lockfile and stream-json from package.json dependencies.

^{This description was created by}^{for d47929e. You can customize this summary. It will automatically update as commits are pushed.}

This reverts commit 1be30fc.

KJ7LNW · 2025-06-15T21:21:31Z

See also: #4468

Fix race condition where safeWriteJson would fail with ENOENT errors during lock acquisition when the parent directory was just created. The issue occurred when the directory creation hadn't fully synchronized with the filesystem before attempting to acquire a lock. This happened primarily when Task.saveApiConversationHistory() called the function immediately after creating the task directory. The fix ensures directories exist and are fully synchronized before lock acquisition by: - Creating directories with fs.mkdir({ recursive: true }) - Verifying access to created directories - Setting realpath: false in lock options to allow locking non-existent files Added comprehensive tests for directory creation capabilities. Fixes: #4468 See-also: #4471, #3772, #722 Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>

mrubens · 2025-06-09T17:47:05Z

Reverts #3772

Looks like this causes issues with saving history, and possibly other things.

Important

Reverts atomic JSON file writes using safeWriteJson, replacing with fs.writeFile, and updates related tests and documentation.

Behavior:
- Reverts use of safeWriteJson for JSON file writes, replacing it with fs.writeFile in modelCache.ts, modelEndpointCache.ts, importExport.ts, FileContextTracker.ts, apiMessages.ts, taskMessages.ts, webviewMessageHandler.ts, and McpHub.ts.
- Removes atomic write guarantees and locking mechanisms previously provided by safeWriteJson.
Tests:
- Removes safeWriteJson tests from safeWriteJson.test.ts.
- Updates tests in cache-manager.test.ts and McpHub.test.ts to reflect changes from safeWriteJson to fs.writeFile.
Documentation:
- Deletes use-safeWriteJson.md rule documentation.
Dependencies:
- Removes proper-lockfile and stream-json from package.json dependencies.

^{This description was created by}^{for d47929e. You can customize this summary. It will automatically update as commits are pushed.}

This reverts commit 1be30fc.

KJ7LNW · 2025-06-15T21:21:31Z

See also: #4468

Fix race condition where safeWriteJson would fail with ENOENT errors during lock acquisition when the parent directory was just created. The issue occurred when the directory creation hadn't fully synchronized with the filesystem before attempting to acquire a lock. This happened primarily when Task.saveApiConversationHistory() called the function immediately after creating the task directory. The fix ensures directories exist and are fully synchronized before lock acquisition by: - Creating directories with fs.mkdir({ recursive: true }) - Verifying access to created directories - Setting realpath: false in lock options to allow locking non-existent files Added comprehensive tests for directory creation capabilities. Fixes: #4468 See-also: #4471, #3772, #722 Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>

mrubens · 2025-06-09T17:47:05Z

Reverts #3772

Looks like this causes issues with saving history, and possibly other things.

Important

Reverts atomic JSON file writes using safeWriteJson, replacing with fs.writeFile, and updates related tests and documentation.

Behavior:
- Reverts use of safeWriteJson for JSON file writes, replacing it with fs.writeFile in modelCache.ts, modelEndpointCache.ts, importExport.ts, FileContextTracker.ts, apiMessages.ts, taskMessages.ts, webviewMessageHandler.ts, and McpHub.ts.
- Removes atomic write guarantees and locking mechanisms previously provided by safeWriteJson.
Tests:
- Removes safeWriteJson tests from safeWriteJson.test.ts.
- Updates tests in cache-manager.test.ts and McpHub.test.ts to reflect changes from safeWriteJson to fs.writeFile.
Documentation:
- Deletes use-safeWriteJson.md rule documentation.
Dependencies:
- Removes proper-lockfile and stream-json from package.json dependencies.

^{This description was created by}^{for d47929e. You can customize this summary. It will automatically update as commits are pushed.}

This reverts commit 1be30fc.

KJ7LNW · 2025-06-15T21:21:31Z

See also: #4468

Fix race condition where safeWriteJson would fail with ENOENT errors during lock acquisition when the parent directory was just created. The issue occurred when the directory creation hadn't fully synchronized with the filesystem before attempting to acquire a lock. This happened primarily when Task.saveApiConversationHistory() called the function immediately after creating the task directory. The fix ensures directories exist and are fully synchronized before lock acquisition by: - Creating directories with fs.mkdir({ recursive: true }) - Verifying access to created directories - Setting realpath: false in lock options to allow locking non-existent files Added comprehensive tests for directory creation capabilities. Fixes: #4468 See-also: #4471, #3772, #722 Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>

mrubens · 2025-06-09T17:47:05Z

Reverts #3772

Looks like this causes issues with saving history, and possibly other things.

Important

Reverts atomic JSON file writes using safeWriteJson, replacing with fs.writeFile, and updates related tests and documentation.

Behavior:
- Reverts use of safeWriteJson for JSON file writes, replacing it with fs.writeFile in modelCache.ts, modelEndpointCache.ts, importExport.ts, FileContextTracker.ts, apiMessages.ts, taskMessages.ts, webviewMessageHandler.ts, and McpHub.ts.
- Removes atomic write guarantees and locking mechanisms previously provided by safeWriteJson.
Tests:
- Removes safeWriteJson tests from safeWriteJson.test.ts.
- Updates tests in cache-manager.test.ts and McpHub.test.ts to reflect changes from safeWriteJson to fs.writeFile.
Documentation:
- Deletes use-safeWriteJson.md rule documentation.
Dependencies:
- Removes proper-lockfile and stream-json from package.json dependencies.

^{This description was created by}^{for d47929e. You can customize this summary. It will automatically update as commits are pushed.}

This reverts commit 1be30fc.

KJ7LNW · 2025-06-15T21:21:31Z

See also: #4468

Fix race condition where safeWriteJson would fail with ENOENT errors during lock acquisition when the parent directory was just created. The issue occurred when the directory creation hadn't fully synchronized with the filesystem before attempting to acquire a lock. This happened primarily when Task.saveApiConversationHistory() called the function immediately after creating the task directory. The fix ensures directories exist and are fully synchronized before lock acquisition by: - Creating directories with fs.mkdir({ recursive: true }) - Verifying access to created directories - Setting realpath: false in lock options to allow locking non-existent files Added comprehensive tests for directory creation capabilities. Fixes: #4468 See-also: #4471, #3772, #722 Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>

mrubens · 2025-06-09T17:47:05Z

Reverts #3772

Looks like this causes issues with saving history, and possibly other things.

Important

Reverts atomic JSON file writes using safeWriteJson, replacing with fs.writeFile, and updates related tests and documentation.

Behavior:
- Reverts use of safeWriteJson for JSON file writes, replacing it with fs.writeFile in modelCache.ts, modelEndpointCache.ts, importExport.ts, FileContextTracker.ts, apiMessages.ts, taskMessages.ts, webviewMessageHandler.ts, and McpHub.ts.
- Removes atomic write guarantees and locking mechanisms previously provided by safeWriteJson.
Tests:
- Removes safeWriteJson tests from safeWriteJson.test.ts.
- Updates tests in cache-manager.test.ts and McpHub.test.ts to reflect changes from safeWriteJson to fs.writeFile.
Documentation:
- Deletes use-safeWriteJson.md rule documentation.
Dependencies:
- Removes proper-lockfile and stream-json from package.json dependencies.

^{This description was created by}^{for d47929e. You can customize this summary. It will automatically update as commits are pushed.}

This reverts commit 1be30fc.

KJ7LNW · 2025-06-15T21:21:31Z

See also: #4468

Fix race condition where safeWriteJson would fail with ENOENT errors during lock acquisition when the parent directory was just created. The issue occurred when the directory creation hadn't fully synchronized with the filesystem before attempting to acquire a lock. This happened primarily when Task.saveApiConversationHistory() called the function immediately after creating the task directory. The fix ensures directories exist and are fully synchronized before lock acquisition by: - Creating directories with fs.mkdir({ recursive: true }) - Verifying access to created directories - Setting realpath: false in lock options to allow locking non-existent files Added comprehensive tests for directory creation capabilities. Fixes: #4468 See-also: #4471, #3772, #722 Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>

mrubens · 2025-06-09T17:47:05Z

Reverts #3772

Looks like this causes issues with saving history, and possibly other things.

Important

Reverts atomic JSON file writes using safeWriteJson, replacing with fs.writeFile, and updates related tests and documentation.

Behavior:
- Reverts use of safeWriteJson for JSON file writes, replacing it with fs.writeFile in modelCache.ts, modelEndpointCache.ts, importExport.ts, FileContextTracker.ts, apiMessages.ts, taskMessages.ts, webviewMessageHandler.ts, and McpHub.ts.
- Removes atomic write guarantees and locking mechanisms previously provided by safeWriteJson.
Tests:
- Removes safeWriteJson tests from safeWriteJson.test.ts.
- Updates tests in cache-manager.test.ts and McpHub.test.ts to reflect changes from safeWriteJson to fs.writeFile.
Documentation:
- Deletes use-safeWriteJson.md rule documentation.
Dependencies:
- Removes proper-lockfile and stream-json from package.json dependencies.

^{This description was created by}^{for d47929e. You can customize this summary. It will automatically update as commits are pushed.}

This reverts commit 1be30fc.

KJ7LNW · 2025-06-15T21:21:31Z

See also: #4468

Fix race condition where safeWriteJson would fail with ENOENT errors during lock acquisition when the parent directory was just created. The issue occurred when the directory creation hadn't fully synchronized with the filesystem before attempting to acquire a lock. This happened primarily when Task.saveApiConversationHistory() called the function immediately after creating the task directory. The fix ensures directories exist and are fully synchronized before lock acquisition by: - Creating directories with fs.mkdir({ recursive: true }) - Verifying access to created directories - Setting realpath: false in lock options to allow locking non-existent files Added comprehensive tests for directory creation capabilities. Fixes: #4468 See-also: #4471, #3772, #722 Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>

mrubens · 2025-06-09T17:47:05Z

Reverts #3772

Looks like this causes issues with saving history, and possibly other things.

Important

Reverts atomic JSON file writes using safeWriteJson, replacing with fs.writeFile, and updates related tests and documentation.

Behavior:
- Reverts use of safeWriteJson for JSON file writes, replacing it with fs.writeFile in modelCache.ts, modelEndpointCache.ts, importExport.ts, FileContextTracker.ts, apiMessages.ts, taskMessages.ts, webviewMessageHandler.ts, and McpHub.ts.
- Removes atomic write guarantees and locking mechanisms previously provided by safeWriteJson.
Tests:
- Removes safeWriteJson tests from safeWriteJson.test.ts.
- Updates tests in cache-manager.test.ts and McpHub.test.ts to reflect changes from safeWriteJson to fs.writeFile.
Documentation:
- Deletes use-safeWriteJson.md rule documentation.
Dependencies:
- Removes proper-lockfile and stream-json from package.json dependencies.

^{This description was created by}^{for d47929e. You can customize this summary. It will automatically update as commits are pushed.}

This reverts commit 1be30fc.

KJ7LNW · 2025-06-15T21:21:31Z

See also: #4468

Fix race condition where safeWriteJson would fail with ENOENT errors during lock acquisition when the parent directory was just created. The issue occurred when the directory creation hadn't fully synchronized with the filesystem before attempting to acquire a lock. This happened primarily when Task.saveApiConversationHistory() called the function immediately after creating the task directory. The fix ensures directories exist and are fully synchronized before lock acquisition by: - Creating directories with fs.mkdir({ recursive: true }) - Verifying access to created directories - Setting realpath: false in lock options to allow locking non-existent files Added comprehensive tests for directory creation capabilities. Fixes: #4468 See-also: #4471, #3772, #722 Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>

Revert "fix: use safeWriteJson for all JSON file writes (#3772)"
d47929e
This reverts commit 1be30fc.

mrubens requested review from cte and jr as code owners June 9, 2025 17:47

github-project-automationBot added this to Roo Code Roadmap and Roo Code Roadmap Jun 9, 2025

github-project-automationBot moved this to Triage in Roo Code Roadmap Jun 9, 2025

github-project-automationBot moved this to New in Roo Code Roadmap Jun 9, 2025

dosubotBot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 9, 2025

jr approved these changes Jun 9, 2025
View reviewed changes

dosubotBot added the lgtm This PR has been approved by a maintainer label Jun 9, 2025

cte approved these changes Jun 9, 2025
View reviewed changes

daniel-lxs approved these changes Jun 9, 2025
View reviewed changes

mrubens merged commit 8d2eeda into mainJun 9, 2025

mrubens deleted the revert-3772-use-safe-write-json-for-all-files branch June 9, 2025 17:53

github-project-automationBot moved this from New to Done in Roo Code Roadmap Jun 9, 2025

github-project-automationBot moved this from Triage to Done in Roo Code Roadmap Jun 9, 2025

KJ7LNW mentioned this pull request Jun 15, 2025
Task can't be opened #722
Closed

KJ7LNW mentioned this pull request Jun 16, 2025
fix: use safeWriteJson for all JSON file writes with race condition fix #4733
Merged