Skip to content
This repository was archived by the owner on May 15, 2026. It is now read-only.

fix(mcp): Revert changes causing startup issues and remove refresh notifications - #6878

Merged
mrubens merged 4 commits into
mainfrom
fix/mcp-startup-issues-revert
Aug 9, 2025
Merged

fix(mcp): Revert changes causing startup issues and remove refresh notifications#6878
mrubens merged 4 commits into
mainfrom
fix/mcp-startup-issues-revert

Conversation

@hannesrudolph

@hannesrudolphhannesrudolph commented Aug 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR reverts the optimization that caused MCP servers to fail on startup and permanently removes the MCP refresh info notifications from the extension logic. The UI already provides a green indicator for MCP status, so duplicative VS Code popups are unnecessary.

Problem

PR #6779 introduced an optimization to avoid unnecessary MCP server refreshes on settings save, which led to MCP servers failing on startup.

Solution

  1. Revert the problematic change from PR fix: prevent unnecessary MCP server refresh on settings save (#6772) #6779 to restore stable MCP startup.

  2. Remove all VS Code information notifications related to MCP refresh in the backend:

    • "already refreshing"
    • "refreshing all"
    • "active global/project servers"
    • "all refreshed"
      The UI status indicator remains the single source of truth for user feedback.

  3. Restore test coverage for the webview message handler MCP toggle path to prevent regressions.

Changes Made

Rationale

  • Reduces user-facing noise and avoids redundant UX (green UI indicator suffices)
  • Simplifies backend logic, eliminating temporary guards/comments

Testing

  • Unit tests:
    • cd src && npx vitest run core/webview/tests/webviewMessageHandler.spec.ts
    • cd src && npx vitest run services/mcp
  • CI:
    • All checks passing (Analyze, CodeQL, compile, unit tests, integration tests, translations, knip)

Checklist

  • MCP servers start successfully
  • UI indicator remains the only user-facing refresh signal
  • Tests updated and passing
  • No user-facing regressions

@hannesrudolph
Revert "fix: prevent unnecessary MCP server refresh on settings save (#…
eceda36
…6772) (#6779)"
This reverts commit 8d05bc1.
@hannesrudolph
fix(mcp): Revert changes causing startup issues and temporarily disab…
949c90f
…le notifications
- Reverted PR #6779 which prevented unnecessary MCP server refreshes but caused startup failures
- Temporarily disabled MCP notification popups as a stopgap solution
- Added TODO comments explaining the temporary nature of disabled notifications
- This allows MCP servers to function properly while a more robust solution is developed
CopilotAI review requested due to automatic review settings August 9, 2025 17:27
@dosubotdosubotBot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Aug 9, 2025
@hannesrudolphhannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Aug 9, 2025
ghost
ghost reviewed Aug 9, 2025
View reviewed changes

@ghostghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! The revert approach is a pragmatic solution to fix the MCP startup issues. I've reviewed the changes and have some suggestions for improvement.

Comment threadsrc/services/mcp/McpHub.ts Outdated
Comment threadsrc/core/webview/__tests__/webviewMessageHandler.spec.ts
Comment threadsrc/services/mcp/McpHub.ts Outdated
Comment threadsrc/core/webview/webviewMessageHandler.ts
CopilotAI reviewed Aug 9, 2025

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@hannesrudolphhannesrudolph changed the title fix(mcp): Revert changes causing startup issues and temporarily disable notificationsfix(mcp): Revert changes causing startup issues and disable notificationsAug 9, 2025
@hannesrudolphhannesrudolph changed the title fix(mcp): Revert changes causing startup issues and disable notificationsfix(mcp): Revert changes causing startup issues and remove refresh notificationsAug 9, 2025
@hannesrudolphhannesrudolph moved this from Triage to PR [Needs Prelim Review] in Roo Code RoadmapAug 9, 2025
@mrubens
mrubens merged commit 75b861c into mainAug 9, 2025
10 checks passed
@dosubotdosubotBot added the lgtm This PR has been approved by a maintainer label Aug 9, 2025
@mrubens
mrubens deleted the fix/mcp-startup-issues-revert branch August 9, 2025 18:28
@github-project-automationgithub-project-automationBot moved this from PR [Needs Prelim Review] to Done in Roo Code RoadmapAug 9, 2025
@github-project-automationgithub-project-automationBot moved this from New to Done in Roo Code RoadmapAug 9, 2025
@ghostghost mentioned this pull request Aug 9, 2025
Closed
@daniel-lxsdaniel-lxs mentioned this pull request Aug 12, 2025
Closed
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@ctecteAwaiting requested review from cte
@jrjrAwaiting requested review from jr
+2 more reviewers
@mrubensmrubensmrubens approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugSomething isn't workingIssue/PR - TriageNew issue. Needs quick review to confirm validity and assign labels.lgtmThis PR has been approved by a maintainersize:LThis PR changes 100-499 lines, ignoring generated files.

Projects

No open projects
Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hannesrudolph@mrubens