feat: enable CPU throttling with --cpuThrottle flag - #30
Merged
Conversation
goooseman
commented
Jul 18, 2022
ContributorAuthor
@Rowno ping ping 🏓 |
Rowno
reviewed
Jul 19, 2022
Uh oh!
There was an error while loading. Please reload this page.
Rowno
reviewed
Jul 20, 2022
Uh oh!
There was an error while loading. Please reload this page.
goooseman
commented
Jul 25, 2022
ContributorAuthor
@Rowno lets merge it? 😉 |
Rowno
commented
Jul 31, 2022
Owner
It looks like your new unit test is failing consistently in CI on |
goooseman
commented
Jul 31, 2022
ContributorAuthor
@Rowno checking... |
goooseman
commented
Jul 31, 2022
ContributorAuthor
@Rowno I see it is running right now, waiting for the tests to fail BTW, don't you think we should enabled CI also on PR, not only in I can help you with that, if you want. |
goooseman
commented
Jul 31, 2022
ContributorAuthor
@Rowno I see where the test fail, maybe the threshold is too low, I will update the test in a separate PR |
Rowno
commented
Jul 31, 2022
Owner
Odd, CI should be running for pul requests 🤔 |
goooseman
commented
Jul 31, 2022
ContributorAuthor
@Rowno creating a PR with test fix + CI config right now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature description
To get more accurate results for comparison it is a good idea to run Chrome with 4x-8x CPU throttling. This way the results will be less influenced by other processes running on the same machine.
This PR adds a special
--cpuThrottlewhich is 1 by default not to change the default behavior. User can set it to any number value (e.g.--cpuThrottle 4) to enable CPU throttling.PR description
ReactBenchmarktest/cli.js) to make sure this option works correctlyP.S. I was using this project for my personal needs and I have much more changes to contribute in the future, such as:
onReadycallback is called (useful for async tests)