Feat/exportlinks - #548
Open
emelalkim wants to merge 10 commits into
Open
Conversation
Enables optional chaining (?.) and nullish coalescing (??) which are supported by Node >= 16 but blocked by the previous ecmaVersion: 2018. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…e links
Accepts a list of {subject, study, aimuid} pairs and returns per-study
AES-256-CBC encrypted URLs along with AIM comment and optionally study
description (studyDesc query param, default false). Output format is
text (tab-separated) or json via outputType param. Includes tests.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…d, use narrative comment - Change method from POST to PUT - Make aimuid optional; comment and name default to empty string when omitted - Add name field (ImageAnnotation.name.value) to output - Use the narrative part of comment (after ~~) instead of the DICOM metadata prefix Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… coercion - Add reply.sent guard so the handler exits immediately if the rights check already sent an unauthorized response - Accept both boolean true and string "true" for studyDesc query param to handle Fastify query string coercion edge cases Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Query params
getPatientStudiesInternal expects filter to be an array or undefined;
passing {} caused filter.join to throw since objects have no join method.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…y access requestQuery.filterDSO is accessed without a null guard in getPatientStudiesInternal, so undefined caused a crash. Empty object is the correct no-op value; undefined is still correct for filter. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…criptions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
All seven reply.send() calls inside epadThickRightsCheck now throw so errors bubble up to the auth hook's single res.send(err), preventing the "reply already sent" error from Fastify seeing multiple responses. The inner catch re-throws for the same reason, and the unused reply parameter is removed from the function signature. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Filter out empty/null values before joining with tabs so that missing study_desc, name, or comment fields don't produce stray tab characters in the plain-text response. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Wrap the CouchDB AIM fetch in a try/catch so any failure (missing doc, DB unavailable, unexpected shape) leaves name and comment empty instead of crashing the whole request. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.