Uh oh!
There was an error while loading. Please reload this page.
panda - #5
Conversation
jwo
commented
Dec 20, 2013
Hi! is the "show" directory intended to me in the commit? |
jwo
commented
Dec 20, 2013
I'm going to assume "/show" shouldn't be here.... So, great job! Of note, on https://github.com/var114/abtvar/blob/master/lib/abtvar/answers.rb#L3
Your gem does this: defaboutVar(answer)ifanswer == 'Y'puts"Because she can code in Ruby"elseputs"You suck JavaChips"endenda Gem is a library, and so it shouldn't really "puts" --- it should just return data based on your input. In this case, it would defabout(answer)ifanswer == 'Y'"Because she can code in Ruby"else"You suck JavaChips"endend(JavaChips made me laugh) 😆 Then in your calling code, putsBio.new.about(answer) |
var114
commented
Dec 20, 2013
oh no. I don’t know how that go in there.
|
jwo
commented
Dec 20, 2013
About “show” —— it probably existed about you did a “git commit -am ‘message’” That adds everything… To prevent those, you can “git status” to see what’s there that you want to commit… you’ll learn that over time. Also, doing “git add -p” and then "git commit” as 2 separate commands is cool if you want TOTAL CONTROL OVER THE GITS. :) On Friday, December 20, 2013 at 1:37 PM, var114 wrote:
|
There was a problem hiding this comment.
Do you think this will work? I don't see the about.erb anywhere for this to render thoughts?
There was a problem hiding this comment.
sorry jesse,
the holidays are making me clumsy…I forgot to do a last repo update. now I have a layout.erb and about.erb in my views folder.
On Jan 2, 2014, at 10:28 AM, Jesse Wolgamott notifications@github.com wrote:
In niner.rb:
-Bundler.require
+require 'sinatra'
+require 'sinatra/reloader'
+
+Bundler.require
+
+enable :session
+
+x = Abtvar::Bio.new
+puts x.awesome_reply
+
+
- get '/' do
- session[:about] = Abtvar::Bio.new
- @random_answer = session[:about].awesome_reply
- erb :about
Do you think this will work? I don't see the about.erb anywhere for this to render thoughts?—
Reply to this email directly or view it on GitHub.
jwo
commented
Jan 2, 2014
Looks great! Nicely done. Do you have any question about gems? |
No description provided.