Don't collapse `\` continuations inside commented BNGL lines by wshlavacek · Pull Request #79 · RuleWorld/PyBioNetGen

wshlavacek · 2026-05-10T21:48:19Z

Summary

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the regex doesn't currently respect comments. A commented-out

```

foo()=if(t<42,0,\


immediately above a live
\`\`\`
foo()=if(t<42,9.899,\

glues both into the comment, and the live definition silently disappears from the rendered `.bngl` (and from any `.net` BNG2.pl generates downstream).

Fix

Anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

```python
mstr = re.sub(r"^([^#\n]*)\\n", r"\1", mstr, flags=re.MULTILINE)


## Test plan
- [ ] Existing CI passes
- [ ] A model with a commented-out \`\\\`-continuation immediately above a live function definition preserves the live definition through round-trip

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the previous regex didn't respect comments: a commented-out # foo()=if(t<42,0,\ immediately above a live foo()=if(t<42,9.899,\ glued both into the comment, and the live definition silently disappeared from the rendered `.bngl` (and from any `.net` BNG2.pl generated downstream). Fix: anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

wshlavacek · 2026-05-10T21:48:19Z

Summary

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the regex doesn't currently respect comments. A commented-out

```

foo()=if(t<42,0,\


immediately above a live
\`\`\`
foo()=if(t<42,9.899,\

glues both into the comment, and the live definition silently disappears from the rendered `.bngl` (and from any `.net` BNG2.pl generates downstream).

Fix

Anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

```python
mstr = re.sub(r"^([^#\n]*)\\n", r"\1", mstr, flags=re.MULTILINE)


## Test plan
- [ ] Existing CI passes
- [ ] A model with a commented-out \`\\\`-continuation immediately above a live function definition preserves the live definition through round-trip

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the previous regex didn't respect comments: a commented-out # foo()=if(t<42,0,\ immediately above a live foo()=if(t<42,9.899,\ glued both into the comment, and the live definition silently disappeared from the rendered `.bngl` (and from any `.net` BNG2.pl generated downstream). Fix: anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

wshlavacek · 2026-05-10T21:48:19Z

Summary

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the regex doesn't currently respect comments. A commented-out

```

foo()=if(t<42,0,\


immediately above a live
\`\`\`
foo()=if(t<42,9.899,\

glues both into the comment, and the live definition silently disappears from the rendered `.bngl` (and from any `.net` BNG2.pl generates downstream).

Fix

Anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

```python
mstr = re.sub(r"^([^#\n]*)\\n", r"\1", mstr, flags=re.MULTILINE)


## Test plan
- [ ] Existing CI passes
- [ ] A model with a commented-out \`\\\`-continuation immediately above a live function definition preserves the live definition through round-trip

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the previous regex didn't respect comments: a commented-out # foo()=if(t<42,0,\ immediately above a live foo()=if(t<42,9.899,\ glued both into the comment, and the live definition silently disappeared from the rendered `.bngl` (and from any `.net` BNG2.pl generated downstream). Fix: anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

wshlavacek · 2026-05-10T21:48:19Z

Summary

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the regex doesn't currently respect comments. A commented-out

```

foo()=if(t<42,0,\


immediately above a live
\`\`\`
foo()=if(t<42,9.899,\

glues both into the comment, and the live definition silently disappears from the rendered `.bngl` (and from any `.net` BNG2.pl generates downstream).

Fix

Anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

```python
mstr = re.sub(r"^([^#\n]*)\\n", r"\1", mstr, flags=re.MULTILINE)


## Test plan
- [ ] Existing CI passes
- [ ] A model with a commented-out \`\\\`-continuation immediately above a live function definition preserves the live definition through round-trip

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the previous regex didn't respect comments: a commented-out # foo()=if(t<42,0,\ immediately above a live foo()=if(t<42,9.899,\ glued both into the comment, and the live definition silently disappeared from the rendered `.bngl` (and from any `.net` BNG2.pl generated downstream). Fix: anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

wshlavacek · 2026-05-10T21:48:19Z

Summary

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the regex doesn't currently respect comments. A commented-out

```

foo()=if(t<42,0,\


immediately above a live
\`\`\`
foo()=if(t<42,9.899,\

glues both into the comment, and the live definition silently disappears from the rendered `.bngl` (and from any `.net` BNG2.pl generates downstream).

Fix

Anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

```python
mstr = re.sub(r"^([^#\n]*)\\n", r"\1", mstr, flags=re.MULTILINE)


## Test plan
- [ ] Existing CI passes
- [ ] A model with a commented-out \`\\\`-continuation immediately above a live function definition preserves the live definition through round-trip

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the previous regex didn't respect comments: a commented-out # foo()=if(t<42,0,\ immediately above a live foo()=if(t<42,9.899,\ glued both into the comment, and the live definition silently disappeared from the rendered `.bngl` (and from any `.net` BNG2.pl generated downstream). Fix: anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

wshlavacek · 2026-05-10T21:48:19Z

Summary

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the regex doesn't currently respect comments. A commented-out

```

foo()=if(t<42,0,\


immediately above a live
\`\`\`
foo()=if(t<42,9.899,\

glues both into the comment, and the live definition silently disappears from the rendered `.bngl` (and from any `.net` BNG2.pl generates downstream).

Fix

Anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

```python
mstr = re.sub(r"^([^#\n]*)\\n", r"\1", mstr, flags=re.MULTILINE)


## Test plan
- [ ] Existing CI passes
- [ ] A model with a commented-out \`\\\`-continuation immediately above a live function definition preserves the live definition through round-trip

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the previous regex didn't respect comments: a commented-out # foo()=if(t<42,0,\ immediately above a live foo()=if(t<42,9.899,\ glued both into the comment, and the live definition silently disappeared from the rendered `.bngl` (and from any `.net` BNG2.pl generated downstream). Fix: anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

wshlavacek · 2026-05-10T21:48:19Z

Summary

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the regex doesn't currently respect comments. A commented-out

```

foo()=if(t<42,0,\


immediately above a live
\`\`\`
foo()=if(t<42,9.899,\

glues both into the comment, and the live definition silently disappears from the rendered `.bngl` (and from any `.net` BNG2.pl generates downstream).

Fix

Anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

```python
mstr = re.sub(r"^([^#\n]*)\\n", r"\1", mstr, flags=re.MULTILINE)


## Test plan
- [ ] Existing CI passes
- [ ] A model with a commented-out \`\\\`-continuation immediately above a live function definition preserves the live definition through round-trip

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the previous regex didn't respect comments: a commented-out # foo()=if(t<42,0,\ immediately above a live foo()=if(t<42,9.899,\ glued both into the comment, and the live definition silently disappeared from the rendered `.bngl` (and from any `.net` BNG2.pl generated downstream). Fix: anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

wshlavacek · 2026-05-10T21:48:19Z

Summary

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the regex doesn't currently respect comments. A commented-out

```

foo()=if(t<42,0,\


immediately above a live
\`\`\`
foo()=if(t<42,9.899,\

glues both into the comment, and the live definition silently disappears from the rendered `.bngl` (and from any `.net` BNG2.pl generates downstream).

Fix

Anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

```python
mstr = re.sub(r"^([^#\n]*)\\n", r"\1", mstr, flags=re.MULTILINE)


## Test plan
- [ ] Existing CI passes
- [ ] A model with a commented-out \`\\\`-continuation immediately above a live function definition preserves the live definition through round-trip

`BNGFile.strip_actions` folds trailing-backslash line continuations before the action parser sees them, but the previous regex didn't respect comments: a commented-out # foo()=if(t<42,0,\ immediately above a live foo()=if(t<42,9.899,\ glued both into the comment, and the live definition silently disappeared from the rendered `.bngl` (and from any `.net` BNG2.pl generated downstream). Fix: anchor the regex to start-of-line and require no `#` between that and the trailing `\` — comment lines keep their continuation markers as part of the comment body, which is what BNG2.pl itself does.

wshlavacek mentioned this pull request May 10, 2026
Accept trailing whitespace between \ and newline in line continuations #85
Merged
2 tasks

jrfaeder merged commit e6588db into RuleWorld:mainMay 11, 2026
17 checks passed

wshlavacek deleted the modelapi-b18-comment-line-continuation branch May 11, 2026 17:07