Feature Spaet, Mourier, and Rummer 2026 paper - #111
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Luen <Luen@users.noreply.github.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
🟢 Claude BugBot Analysis
No bugs found in the changes. The diff adds a featured publication (content + JSON-LD) to the publications and women-in-science pages, following existing patterns exactly (same rendering loop shape, same author-splitting and JSON-LD construction as the pre-existing journalArticles/bookChapters code), with correctly matched anchor id/href pairs and no null derefs, off-by-ones, or structural issues.
No bugs were detected in this PR.
Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Luen <Luen@users.noreply.github.com>
Luen
commented
Aug 14, 2026
Featured publications now come from RummerLab instead of a hardcoded list:
Merge RummerLab/rummerlab-website#194 first so production exposes the papers API. Until then, featured falls back to a RummerLab publications link. Follow-up: #112 (full journal-article list from RummerLab APIs). |
There was a problem hiding this comment.
🔴 Claude BugBot Analysis
Found 1 potential bug in this PR.
high: 1
The PR adds an AGENTS.md rule prohibiting hardcoded featured publications, but the women-in-science page hardcodes the newly featured paper's title, authors, journal, and DOI in JSX and JSON-LD instead of pulling it from the RummerLab featured-papers API as the publications page correctly does.
| </p> | ||
| </div> | ||
| <article className="mt-12 rounded-2xl border border-slate-200 dark:border-slate-700 bg-slate-50 dark:bg-slate-900 p-8"> |
There was a problem hiding this comment.
🟠 HIGH: Hardcoded featured publication violates newly-added AGENTS.md rule
This same PR adds the rule to AGENTS.md (line 46): "Team data and featured papers come from RummerLab APIs (... /api/papers/featured). Do not hardcode featured publications." Yet the new <article> block in app/women-in-science/page.tsx (lines 119-160) hardcodes the title, authors, journal citation, and DOI of the Spaet/Mourier/Rummer 2026 paper directly in JSX, rather than sourcing it from getRummerlabFeaturedPapers() (which is correctly used for this purpose on app/publications/page.tsx). Only the PDF link (spaetPaper) is fetched from the API via getRummerlabPapers(); the rest of the featured-publication content is static and will go stale/incorrect if the paper's metadata changes, directly contradicting the rule this PR itself introduces. Fix by deriving the headline/authors/journal/DOI/date from the fetched paper object (e.g. via getRummerlabFeaturedPapers() or the spaetPaper record) instead of hardcoding them.
Additional Locations
app/women-in-science/page.tsx:296— The JSON-LDsubjectOfblock also hardcodes the same paper's title, authors, publisher, and adatePublishedof '2026-08-14' (today's date, not the paper's actual publication date) instead of sourcing it from the fetched paper data.
Women in Science and featured lists now use only RummerLab /api/papers data, and nanoid is overridden to 3.3.18 for the postcss transitive dependency. Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Luen <Luen@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Claude BugBot Analysis
No new bugs found. The previously reported hardcoded-featured-publication issue in app/women-in-science/page.tsx is fixed: both the JSX article block and the JSON-LD subjectOf block now derive title, URL, and date from the fetched RummerLab paper data via findRummerlabPaper/getRummerlabFeaturedPapers instead of hardcoded strings.
No bugs were detected in this PR.
Uh oh!
There was an error while loading. Please reload this page.
Summary
/publications#featured.#featured,#articles, and#booksanchors used in the publications menu.Test plan
/publications#featuredand confirm the Spaet, Mourier, and Rummer 2026 card, DOI, and PDF links work./women-in-scienceand confirm the latest-research card and links.Made with Cursor