Uh oh!
There was an error while loading. Please reload this page.
WCAG related accessibility fixes to student facing pages - #1401
Open
ascholerChemeketa wants to merge 9 commits into
Open
WCAG related accessibility fixes to student facing pages#1401ascholerChemeketa wants to merge 9 commits into
ascholerChemeketa wants to merge 9 commits into
Conversation
added 9 commits
August 20, 2026 16:55
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets WCAG/WAVE “hard fail” accessibility issues and improves UI consistency across student-facing and auth/admin pages by introducing semantic HTML updates, better ARIA/labeling, and centralizing colors via CSS custom properties.
Changes:
- Introduces a shared
:rootcolor token set inrs-core.cssand refactors multiple CSS files to use those variables for contrast/theming consistency. - Improves page semantics/accessibility by adding
<main>wrappers and upgrading some tables/inputs with more appropriate markup. - Updates the course switcher UI to a dropdown with status messaging and more robust client-side error handling.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| components/rsptx/templates/staticAssets/main.css | Switches to flex layout for sticky-footer structure on non-PTX pages. |
| components/rsptx/templates/staticAssets/css/subchapoverview.css | Replaces hard-coded colors with shared CSS variables. |
| components/rsptx/templates/staticAssets/css/studentreport.css | Replaces hard-coded colors with shared CSS variables and contrast tweaks. |
| components/rsptx/templates/staticAssets/css/student_detail.css | Replaces hard-coded colors with shared CSS variables. |
| components/rsptx/templates/staticAssets/css/rs-core.css | Adds CSS variable palette and updates “bootstrap-like” core styles. |
| components/rsptx/templates/staticAssets/css/peer.css | Replaces hard-coded colors with shared CSS variables. |
| components/rsptx/templates/staticAssets/css/lti.css | Uses shared danger background variable for error rows. |
| components/rsptx/templates/staticAssets/css/auth.css | Applies shared variables and refines auth/danger-zone styling. |
| components/rsptx/templates/staticAssets/css/assignmentoverview.css | Uses shared surface/text variables for stat cells. |
| components/rsptx/templates/staticAssets/css/assignment.css | Replaces hard-coded colors with shared variables and improves dropdown theming defaults. |
| components/rsptx/templates/staticAssets/css/admin.css | Refactors admin styling to shared variables for maintainability/contrast. |
| components/rsptx/templates/staticAssets/course.css | Adds styling for the new course chooser toggle button. |
| components/rsptx/templates/staticAssets/assignment/assignment_block.css | Adjusts success/error colors (contrast) in assignment blocks. |
| components/rsptx/templates/legal/hecvat.html | Minor contrast tweak for “N/A” answer color. |
| components/rsptx/templates/legal/_legal_base.html | Tweaks legal template styling and removes a breadcrumb block. |
| components/rsptx/templates/book/course/current_course.html | Replaces course select with dropdown + JS status/error handling. |
| components/rsptx/templates/assignment/student/studentreport.html | Improves table header semantics by using <th> in Grades and adds headers to Recent Activity. |
| components/rsptx/templates/admin/auth/profile.html | Improves form labeling/ARIA and clarifies delete-account section structure. |
| components/rsptx/templates/admin/auth/login.html | Overrides auth navbar items (empty) for the login page. |
| components/rsptx/templates/admin/auth/donate.html | Adds an explicit label for the “Other” donation amount field. |
| components/rsptx/templates/admin/auth/courses.html | Adds ARIA/labeling improvements for course selection and filtering controls. |
| components/rsptx/templates/admin/auth/_auth_base.html | Introduces nav_items block and wraps content in <main>. |
| components/rsptx/templates/_base.html | Wraps main content in <main> for improved document structure. |
| bases/rsptx/admin_server_api/routers/auth.py | Propagates student_page: True context for profile-related views. |
Suppressed comments (1)
components/rsptx/templates/staticAssets/main.css:35
bodyis now a flex column withmain { flex: 1; }, but.footeris stillposition: absoluteandbodyno longer has a bottom margin. This can cause the footer to overlap page content (especially on short pages) and defeats the sticky-footer flex layout.
.footer {
position: absolute;
bottom: 0;
width: 100%;
height: 50px;
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
30
to
+31
| <input class="form-check-input" type="radio" name="course_name" | ||
| id="ic_{{ course.course_name }}" value="{{ course.course_name }}"> | ||
| id="ic_{{ course.course_name }}" value="{{ course.course_name }}" aria-label="Text filter for course or author name"> |
Comment on lines
76
to
+80
| <table class="nodec"> | ||
| <tr> | ||
| <th>Timestamp</th> | ||
| <th>Event</th> | ||
| <th>Div ID</th> |
Comment on lines
458
to
+462
| .form-check { | ||
| position: relative; | ||
| display: block; | ||
| padding-left: 1.25rem; | ||
| } | ||
| .form-check-input { | ||
| position: absolute; | ||
| margin-top: 0.3rem; | ||
| margin-left: -1.25rem; | ||
| display: flex; | ||
| gap: 20px; |
Comment on lines
+21
to
+25
| {% block nav_items %} | ||
| <div class="ml-auto nav-item"> | ||
| <a class="nav-link" href="/admin/auth/login">Log In</a> | ||
| </div> | ||
| <div class="nav-item"> | ||
| <a class="nav-link" href="https://blog.runestone.academy/pages/faq.html">Help</a> | ||
| </div> | ||
| {% endblock %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection of fixes to remove hard fails using WAVE to audit student facing pages.
This pull request introduces several improvements across the codebase, focusing on accessibility enhancements, UI/UX updates, and improved maintainability. The main changes include adding ARIA attributes for accessibility, updating the course switching UI to a dropdown with improved feedback, and standardizing the use of CSS variables for theming. Additionally, minor UI refinements and template adjustments were made for consistency and clarity.
Accessibility improvements:
courses.htmlandprofile.htmlfor better screen reader support. [1][2][3][4][5]studentreport.htmlto use<th>elements for semantic correctness and accessibility. [1][2]UI/UX enhancements:
current_course.html, providing clearer feedback and improved interaction. Updated the associated JavaScript for better error handling and accessibility. [1][2][3]<main>element wrapper to base templates for improved document structure and accessibility. [1][2]Styling and theming:
admin.cssto use CSS variables for colors, improving maintainability and theming consistency across admin pages. Updated button, link, and banner styles accordingly. [1][2][3][4][5]assignment_block.cssfor better visual contrast.Template and content updates:
Context flag propagation:
"student_page": Truecontext variable is consistently passed to profile-related views for correct template rendering. [1][2][3][4]