Uh oh!
There was an error while loading. Please reload this page.
코스발견 배너 Firestore → 서버 API 전환 - #408
Conversation
Runnect 서버에 GET /api/banner가 새로 생겨서(Runnect-Spring-Boot-Server#209/#210), Firestore "data" 컬렉션을 직접 구독하던 RemoteBannerDataSource를 BannerService(Retrofit) 호출로 교체. DiscoverBanner(index/imageUrl/linkUrl) 구조는 그대로라 상위 Repository/ViewModel/Adapter는 변경 없음.
Warning Review limit reached
Next review available in:32 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
작업 배경
runnect-ios단일 프로젝트로 통합하는 과정에서, 새 프로젝트에 Firestore API가 비활성화돼 있어 코스발견 배너가 안 뜨는 회귀가 발생함RemoteBannerDataSource가 아직 Firestore를 직접 참조하는 구코드였고, 이를 자체 서버 API로 전환하는 작업이feature/banner-server-api-migration브랜치에 이미 완성돼 있었지만develop에 머지되지 않은 상태였음77b6e0ec)을 최신develop기준으로 cherry-pick하여 반영, Firestore 의존성 자체를 제거변경 사항
BannerService.kt(신규)/api/banner서버 엔드포인트 Retrofit 인터페이스ResponseGetBanner.kt(신규)RemoteBannerDataSource.ktaddSnapshotListener대신BannerService.getBanners()호출로 교체ServiceModule.ktFirebaseFirestoreDI 프로바이더 제거,BannerService프로바이더 추가영향 범위
Test Plan
./gradlew :app:assembleDebug빌드 성공GET https://api.runnect.site/api/banner200 응답 및 배너 3건 정상 파싱 확인🤖 Generated with Claude Code