Skip to content

feat(serverless): upsert source on deploy - #113

Merged
Ryank90 merged 2 commits into
feat/workers-state-deploy-waitfrom
feat/deploy-upsert
Sep 7, 2026
Merged

feat(serverless): upsert source on deploy#113
Ryank90 merged 2 commits into
feat/workers-state-deploy-waitfrom
feat/deploy-upsert

Conversation

@Ryank90

@Ryank90Ryank90 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • serverless deploy creates when --id is new (POST createApp) and replaces source when the app already exists (PATCH appSource only).
  • --gpu-type is required on create only. Explicit create-only flags (--gpu-type, worker settings, --volume, --env / --env-file, --name) on an existing app are rejected; use apps scale / apps env.
  • GET probes before upload. A create 409 races into the same source PATCH. --wait still applies on both paths.

Test plan

  • First deploy: runware serverless deploy ./app.py --id my-app --gpu-type h100 creates
  • Second deploy: runware serverless deploy ./app.py --id my-app uploads source and the app goes initializing
  • Second deploy with --gpu-type / --env errors and does not PATCH
  • --wait on an update returns after active or failed
  • Source update on a stopped app returns API 409

@coderabbitai

coderabbitaiBot commented Sep 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include coderabbit-review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 20f563d7-341b-4225-908b-f9968cb9921b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Create when --id is new and PATCH appSource when it already exists, rejecting
create-only flags on update so leftover env or scale flags cannot apply.
CI golangci-lint v2.12 treats the fourth ".env" literal as a failure;
share envDotfile across pack, env, and deploy tests.
@Ryank90
Ryank90 merged commit e47a9ba into rc/serverlessSep 7, 2026
7 checks passed
@Ryank90
Ryank90 deleted the feat/deploy-upsert branch September 7, 2026 10:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Ryank90@danmrichards