Uh oh!
There was an error while loading. Please reload this page.
feat(serverless): upsert source on deploy - #113
Conversation
Important Review skippedAuto reviews are disabled on this repository. To trigger a review, include ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Create when --id is new and PATCH appSource when it already exists, rejecting create-only flags on update so leftover env or scale flags cannot apply.
CI golangci-lint v2.12 treats the fourth ".env" literal as a failure; share envDotfile across pack, env, and deploy tests.
c6c51e4 to
8c025b5CompareUh oh!
There was an error while loading. Please reload this page.
Summary
serverless deploycreates when--idis new (POST createApp) and replaces source when the app already exists (PATCH appSourceonly).--gpu-typeis required on create only. Explicit create-only flags (--gpu-type, worker settings,--volume,--env/--env-file,--name) on an existing app are rejected; useapps scale/apps env.GETprobes before upload. A create409races into the same sourcePATCH.--waitstill applies on both paths.Test plan
runware serverless deploy ./app.py --id my-app --gpu-type h100createsrunware serverless deploy ./app.py --id my-appuploads source and the app goesinitializing--gpu-type/--enverrors and does not PATCH--waiton an update returns afteractiveorfailed